From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Sangwook Lee <sangwook.lee@linaro.org>
Cc: linux-media@vger.kernel.org, mchehab@infradead.org,
laurent.pinchart@ideasonboard.com, kyungmin.park@samsung.com,
hans.verkuil@cisco.com, linaro-dev@lists.linaro.org,
patches@linaro.org, scott.bambrough@linaro.org,
s.nawrocki@samsung.com
Subject: Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor
Date: Fri, 07 Sep 2012 23:40:55 +0200 [thread overview]
Message-ID: <504A69E7.9090900@gmail.com> (raw)
In-Reply-To: <1346944114-17527-1-git-send-email-sangwook.lee@linaro.org>
Hi Sangwook,
On 09/06/2012 05:08 PM, Sangwook Lee wrote:
> This patch adds driver for S5K4ECGX sensor with embedded ISP SoC,
> S5K4ECGX, which is a 5M CMOS Image sensor from Samsung
> The driver implements preview mode of the S5K4ECGX sensor.
> capture (snapshot) operation, face detection are missing now.
> Following controls are supported:
> contrast/saturation/brightness/sharpness
>
> Signed-off-by: Sangwook Lee<sangwook.lee@linaro.org>
> Reviewed-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
Thanks for the update. I've done a few more minor fixes and improved
s_stream() subdev op handling, so it really enables/disables data
stream on the sensor's output. It's pushed to
git://linuxtv.org/snawrocki/media.git samsung_s5k4ecgx
Could you please squash the changes that you are willing to accept
and test if the last patch really does what it is intended to ?
After you send v7 I could add this patch to my tree for v3.7,
unless you want to handle it yourself.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2012-09-07 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:08 [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor Sangwook Lee
2012-09-07 21:40 ` Sylwester Nawrocki [this message]
2012-09-09 16:01 ` Francesco Lavra
2012-09-10 15:04 ` Sylwester Nawrocki
2012-09-10 18:52 ` Francesco Lavra
2012-09-10 20:29 ` Sylwester Nawrocki
2012-09-11 10:00 ` Sangwook Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504A69E7.9090900@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=patches@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sangwook.lee@linaro.org \
--cc=scott.bambrough@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).