From: Hans de Goede <hdegoede@redhat.com>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB
Date: Sun, 09 Sep 2012 23:24:08 +0200 [thread overview]
Message-ID: <504D08F8.3070104@redhat.com> (raw)
In-Reply-To: <1347215768-9843-2-git-send-email-fschaefer.oss@googlemail.com>
Hi,
On 09/09/2012 08:36 PM, Frank Schäfer wrote:
> The gspca_pac7302 driver already provides this control.
>
> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
> ---
> lib/libv4lconvert/control/libv4lcontrol.c | 12 ++++--------
> 1 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index 1272256..3d7a816 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -202,14 +202,10 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
> { 0x145f, 0x013a, 0, NULL, NULL, V4LCONTROL_WANTS_WB, 1500 },
> { 0x2001, 0xf115, 0, NULL, NULL, V4LCONTROL_WANTS_WB, 1500 },
> /* Pac7302 based devices */
> - { 0x093a, 0x2620, 0x0f, NULL, NULL,
> - V4LCONTROL_ROTATED_90_JPEG | V4LCONTROL_WANTS_WB, 1500 },
> - { 0x06f8, 0x3009, 0, NULL, NULL,
> - V4LCONTROL_ROTATED_90_JPEG | V4LCONTROL_WANTS_WB, 1500 },
> - { 0x06f8, 0x301b, 0, NULL, NULL,
> - V4LCONTROL_ROTATED_90_JPEG | V4LCONTROL_WANTS_WB, 1500 },
> - { 0x145f, 0x013c, 0, NULL, NULL,
> - V4LCONTROL_ROTATED_90_JPEG | V4LCONTROL_WANTS_WB, 1500 },
> + { 0x093a, 0x2620, 0x0f, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x06f8, 0x3009, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x06f8, 0x301b, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x145f, 0x013c, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> /* Pac7311 based devices */
> { 0x093a, 0x2600, 0x0f, NULL, NULL, V4LCONTROL_WANTS_WB },
> /* sq905 devices */
>
WANTS_WB does not add a whitebalance control, which these cameras indeed
already have, it adds a (software) autowhitebalance control, which enables
libv4lconvert doing software whitebalance correction. Although your
kernel patch for the pac7302 driver to pick a better default whitebalance
value, probably helps a lot to get the colors less screwed up, in the end
we still need some sort of awb to adjust to changing lightning conditions,
that is what this flag adds, as the pac7302 driver lacks awb.
Regards,
Hans
next prev parent reply other threads:[~2012-09-09 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 18:36 [PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch Frank Schäfer
2012-09-09 18:36 ` [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB Frank Schäfer
2012-09-09 21:24 ` Hans de Goede [this message]
2012-09-10 15:41 ` Frank Schäfer
2012-09-10 18:33 ` Hans de Goede
2012-09-10 20:33 ` Frank Schäfer
2012-09-11 7:33 ` Hans de Goede
2012-09-09 18:36 ` [PATCH 3/3] libv4lconvert: update the list of pac7302 webcams Frank Schäfer
2012-09-09 21:26 ` Hans de Goede
2012-10-09 21:33 ` Robert Abel
2012-09-09 21:21 ` [PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504D08F8.3070104@redhat.com \
--to=hdegoede@redhat.com \
--cc=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).