From: Hans de Goede <hdegoede@redhat.com>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/3] libv4lconvert: update the list of pac7302 webcams
Date: Sun, 09 Sep 2012 23:26:46 +0200 [thread overview]
Message-ID: <504D0996.6010405@redhat.com> (raw)
In-Reply-To: <1347215768-9843-3-git-send-email-fschaefer.oss@googlemail.com>
Hi,
On 09/09/2012 08:36 PM, Frank Schäfer wrote:
> All pac7302 webcams need image rotation, so synchronize the list with the driver.
>
> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
> ---
> lib/libv4lconvert/control/libv4lcontrol.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index 3d7a816..6eea121 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -202,10 +202,21 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
> { 0x145f, 0x013a, 0, NULL, NULL, V4LCONTROL_WANTS_WB, 1500 },
> { 0x2001, 0xf115, 0, NULL, NULL, V4LCONTROL_WANTS_WB, 1500 },
> /* Pac7302 based devices */
> - { 0x093a, 0x2620, 0x0f, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
The 0x0f here is a mask, so this one entry covers all device ids from
0x2620 - 0x262f, so...
> { 0x06f8, 0x3009, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> { 0x06f8, 0x301b, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2620, 0x0f, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2611, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2622, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2624, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2625, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2626, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2627, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2628, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x2629, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x262a, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x093a, 0x262c, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
The addition of all these is not necessary.
> { 0x145f, 0x013c, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
> + { 0x1ae7, 0x2001, 0, NULL, NULL, V4LCONTROL_ROTATED_90_JPEG },
This one is necessary, I'll go and add it right away.
Regards,
Hans
next prev parent reply other threads:[~2012-09-09 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 18:36 [PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch Frank Schäfer
2012-09-09 18:36 ` [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB Frank Schäfer
2012-09-09 21:24 ` Hans de Goede
2012-09-10 15:41 ` Frank Schäfer
2012-09-10 18:33 ` Hans de Goede
2012-09-10 20:33 ` Frank Schäfer
2012-09-11 7:33 ` Hans de Goede
2012-09-09 18:36 ` [PATCH 3/3] libv4lconvert: update the list of pac7302 webcams Frank Schäfer
2012-09-09 21:26 ` Hans de Goede [this message]
2012-10-09 21:33 ` Robert Abel
2012-09-09 21:21 ` [PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504D0996.6010405@redhat.com \
--to=hdegoede@redhat.com \
--cc=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).