From: Bryan O'Donoghue <bod@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Robert Mader <robert.mader@collabora.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
David Heidelberg <david@ixit.cz>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v6 3/5] arm64: dts: qcom: sdm670: label the camss ports instead of endpoints
Date: Wed, 7 Jan 2026 13:36:16 +0000 [thread overview]
Message-ID: <504ff36c-c94d-4f8b-8256-7957b65220ea@kernel.org> (raw)
In-Reply-To: <20260107043044.92485-4-mailingradian@gmail.com>
On 07/01/2026 04:30, Richard Acayan wrote:
> Endpoints cannot be pre-defined since dcf6fb89e6f7 ("media: qcom: camss:
> remove a check for unavailable CAMSS endpoint") was applied, probing all
> endpoint nodes and requiring them to have a remote. There is no sensible
> remote in the SoC devicetree because camera sensors are board-specific.
>
> The ports are meant to be extended by a board devicetree in order to
> define fully configured endpoints and connect the ports to camera
> sensors. For nodes that are only meaningful if extended, labels are
> usually assigned. Label these ports so they can be extended directly.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> index b8a8dcbdfbe3..3eb4eaf7b8d7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -1776,28 +1776,16 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - port@0 {
> + camss_port0: port@0 {
> reg = <0>;
> -
> - camss_endpoint0: endpoint {
> - status = "disabled";
> - };
> };
>
> - port@1 {
> + camss_port1: port@1 {
> reg = <1>;
> -
> - camss_endpoint1: endpoint {
> - status = "disabled";
> - };
> };
>
> - port@2 {
> + camss_port2: port@2 {
> reg = <2>;
> -
> - camss_endpoint2: endpoint {
> - status = "disabled";
> - };
> };
> };
> };
> --
> 2.52.0
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2026-01-07 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 4:30 [PATCH v6 0/5] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2026-01-07 4:30 ` [PATCH v6 1/5] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2026-01-07 4:41 ` Vladimir Zapolskiy
2026-01-07 7:35 ` Krzysztof Kozlowski
2026-01-09 0:09 ` Richard Acayan
2026-01-07 4:30 ` [PATCH v6 2/5] media: i2c: imx355: Support devicetree and power management Richard Acayan
2026-01-07 4:55 ` Vladimir Zapolskiy
2026-01-07 7:34 ` Krzysztof Kozlowski
2026-01-08 3:28 ` Richard Acayan
2026-01-07 13:31 ` Bryan O'Donoghue
2026-01-07 18:49 ` Sakari Ailus
2026-01-08 4:15 ` Richard Acayan
2026-01-07 4:30 ` [PATCH v6 3/5] arm64: dts: qcom: sdm670: label the camss ports instead of endpoints Richard Acayan
2026-01-07 4:59 ` Vladimir Zapolskiy
2026-01-07 13:36 ` Bryan O'Donoghue [this message]
2026-01-07 4:30 ` [PATCH v6 4/5] arm64: dts: qcom: sdm670: add camera mclk pins Richard Acayan
2026-01-07 4:30 ` [PATCH v6 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2026-01-07 5:05 ` Vladimir Zapolskiy
2026-01-07 13:37 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504ff36c-c94d-4f8b-8256-7957b65220ea@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robert.mader@collabora.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox