From: Anders Thomson <aeriksson2@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: tda8290 regression fix
Date: Sat, 15 Sep 2012 19:44:56 +0200 [thread overview]
Message-ID: <5054BE98.8020708@gmail.com> (raw)
In-Reply-To: <5054BD53.7060109@gmail.com>
On 2012-09-15 19:39, Anders Thomson wrote:
> On 2012-09-15 18:34, Mauro Carvalho Chehab wrote:
> > > $ cat /TV_CARD.diff
> > > diff --git a/drivers/media/common/tuners/tda8290.c
> > > b/drivers/media/common/tuners/tda8290.c
> > > index 064d14c..498cc7b 100644
> > > --- a/drivers/media/common/tuners/tda8290.c
> > > +++ b/drivers/media/common/tuners/tda8290.c
> > > @@ -635,7 +635,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)
> > >
> > > dvb_attach(tda827x_attach, fe, priv->tda827x_addr,
> > > priv->i2c_props.adap,&priv->cfg);
> > > + tuner_info("ANDERS: setting switch_addr. was 0x%02x, new
> > > 0x%02x\n",priv->cfg.switch_addr,priv->i2c_props.addr);
> > > priv->cfg.switch_addr = priv->i2c_props.addr;
> > > + priv->cfg.switch_addr = 0xc2 / 2;
> >
> > No, this is wrong. The I2C address is passed by the bridge driver or by
> > the tuner_core attachment, being stored at priv->i2c_props.addr.
> >
> > What's the driver and card you're using?
> >
>
...and here's the modules I'm using
Module Size Used by
hid_sunplus 1321 0
usbhid 29765 0
uinput 6426 2
saa7134_alsa 9359 0
tda1004x 12639 1
saa7134_dvb 22092 0
videobuf_dvb 4106 1 saa7134_dvb
dvb_core 78773 1 videobuf_dvb
ir_kbd_i2c 4473 0
tda827x 8291 2
tda8290 11906 1
tuner 13649 1
uvcvideo 54515 0
videobuf2_core 15467 1 uvcvideo
snd_hda_codec_realtek 46581 1
saa7134 149350 2 saa7134_alsa,saa7134_dvb
videobuf_dma_sg 6504 3 saa7134_alsa,saa7134_dvb,saa7134
videobuf_core 12866 3 videobuf_dvb,saa7134,videobuf_dma_sg
snd_hda_intel 20144 1
snd_hda_codec 59409 2 snd_hda_codec_realtek,snd_hda_intel
v4l2_common 4558 2 tuner,saa7134
videodev 68383 4 tuner,uvcvideo,saa7134,v4l2_common
snd_usb_audio 81087 0
lirc_dev 9954 0
ir_mce_kbd_decoder 2838 0
parport_pc 27310 0
rc_imon_mce 1349 0
v4l2_compat_ioctl32 6796 1 videodev
ir_rc6_decoder 1946 0
videobuf2_vmalloc 1812 1 uvcvideo
snd_usbmidi_lib 15516 1 snd_usb_audio
tveeprom 12721 1 saa7134
snd_hwdep 5006 2 snd_hda_codec,snd_usb_audio
asus_atk0110 7054 0
parport 24807 1 parport_pc
i2c_piix4 7680 0
videobuf2_memops 1638 1 videobuf2_vmalloc
ir_rc5_decoder 1433 0
imon 18432 1
rc_core 10749 8
ir_kbd_i2c,saa7134,ir_mce_kbd_decoder,rc_imon_mce,ir_rc6_decoder,ir_rc5_decoder,imon
pcspkr 1659 0
atiixp 2404 0
rtc_cmos 7570 0
sg 20980 0
snd_rawmidi 14984 1 snd_usbmidi_lib
next prev parent reply other threads:[~2012-09-15 17:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:27 tda8290 regression fix Anders Thomson
2012-09-15 16:34 ` Mauro Carvalho Chehab
2012-09-15 17:39 ` Anders Thomson
2012-09-15 17:44 ` Anders Thomson [this message]
2012-09-15 17:58 ` Mauro Carvalho Chehab
2012-09-15 18:12 ` Anders Thomson
2012-09-15 22:25 ` Mauro Carvalho Chehab
2012-09-16 8:48 ` Anders Thomson
2012-09-18 9:53 ` Mauro Carvalho Chehab
2012-09-19 13:01 ` Anders Thomson
2012-09-19 16:45 ` Mauro Carvalho Chehab
2012-09-19 19:25 ` Anders Thomson
[not found] ` <CAGncdOae+VoAAUWz3x84zUA-TCMeMmNONf_ktNFd1p7c-o5H_A@mail.gmail.com>
2012-09-21 14:49 ` Mauro Carvalho Chehab
[not found] ` <8ed8c988-fa8c-41fc-9f33-cccdceb1b232@email.android.com>
2012-09-23 11:36 ` Mauro Carvalho Chehab
2012-09-23 17:54 ` Anders Thomson
2012-09-23 18:14 ` Mauro Carvalho Chehab
2012-09-23 18:39 ` Anders Thomson
2012-09-23 21:06 ` Anders Thomson
2012-10-01 16:56 ` Anders Thomson
2012-11-15 20:43 ` Anders Thomson
2012-12-04 11:00 ` Anders Thomson
2012-09-15 18:28 ` Anders Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5054BE98.8020708@gmail.com \
--to=aeriksson2@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).