From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:52335 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754605Ab2IOSMy (ORCPT ); Sat, 15 Sep 2012 14:12:54 -0400 Received: by lbbgj3 with SMTP id gj3so3428423lbb.19 for ; Sat, 15 Sep 2012 11:12:52 -0700 (PDT) Message-ID: <5054C521.1090200@gmail.com> Date: Sat, 15 Sep 2012 20:12:49 +0200 From: Anders Thomson MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: "linux-media@vger.kernel.org" Subject: Re: tda8290 regression fix References: <503F4E19.1050700@gmail.com> <20120915133417.27cb82a1@redhat.com> <5054BD53.7060109@gmail.com> <20120915145834.0b763f73@redhat.com> In-Reply-To: <20120915145834.0b763f73@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: > Em Sat, 15 Sep 2012 19:39:31 +0200 > Anders Thomson escreveu: > > > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > > $ cat /TV_CARD.diff > > > > diff --git a/drivers/media/common/tuners/tda8290.c > > > > b/drivers/media/common/tuners/tda8290.c > > > > index 064d14c..498cc7b 100644 > > > > --- a/drivers/media/common/tuners/tda8290.c > > > > +++ b/drivers/media/common/tuners/tda8290.c > > > > @@ -635,7 +635,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe) > > > > > > > > dvb_attach(tda827x_attach, fe, priv->tda827x_addr, > > > > priv->i2c_props.adap,&priv->cfg); > > > > + tuner_info("ANDERS: setting switch_addr. was 0x%02x, new > > > > 0x%02x\n",priv->cfg.switch_addr,priv->i2c_props.addr); > > > > priv->cfg.switch_addr = priv->i2c_props.addr; > > > > + priv->cfg.switch_addr = 0xc2 / 2; > > > > > > No, this is wrong. The I2C address is passed by the bridge driver or by > > > the tuner_core attachment, being stored at priv->i2c_props.addr. > > > > > > What's the driver and card you're using? > > > > > lspci -vv: > > 03:06.0 Multimedia controller: Philips Semiconductors > > SAA7131/SAA7133/SAA7135 Video Broadcast Decoder (rev d1) > > Subsystem: Pinnacle Systems Inc. Device 002f > > There are lots of Pinnacle device supported by saa7134 driver. Without its > PCI ID that's not much we can do. That here, right? lspci -nvv: 03:06.0 0480: 1131:7133 (rev d1) Subsystem: 11bd:002f Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- Also, please post the dmesg showing what happens without and with your patch. Coming. Hold on... > Regards, > Mauro