From: Antti Palosaari <crope@iki.fi>
To: "Rémi Cardona" <remi.cardona@smartjog.com>
Cc: linux-media@vger.kernel.org, liplianin@me.by
Subject: Re: [PATCH 3/6] [media] ds3000: properly report register read errors
Date: Sun, 16 Sep 2012 04:30:13 +0300 [thread overview]
Message-ID: <50552BA5.1000000@iki.fi> (raw)
In-Reply-To: <1347614846-19046-4-git-send-email-remi.cardona@smartjog.com>
On 09/14/2012 12:27 PM, Rémi Cardona wrote:
> This brings both ds3000_readreg() and ds3000_tuner_readreg() in line
> with ds3000_writereg() and ds3000_tuner_writereg() respectively.
>
> Signed-off-by: Rémi Cardona <remi.cardona@smartjog.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Not related, but just guess, register 03 value 12 opens demod I2C gate.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-09-16 1:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 9:27 [PATCH v2 0/6] ds3000 improvements Rémi Cardona
2012-09-14 9:27 ` [PATCH 1/6] [media] ds3000: Declare MODULE_FIRMWARE usage Rémi Cardona
2012-09-16 1:27 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 2/6] [media] ds3000: remove useless 'locking' Rémi Cardona
2012-09-16 1:28 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 3/6] [media] ds3000: properly report register read errors Rémi Cardona
2012-09-16 1:30 ` Antti Palosaari [this message]
2012-09-14 9:27 ` [PATCH 4/6] [media] ds3000: bail out early on i2c failures during firmware load Rémi Cardona
2012-09-16 1:41 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 5/6] [media] ds3000: properly report firmware probing issues Rémi Cardona
2012-09-16 1:44 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 6/6] [media] ds3000: add module parameter to force firmware upload Rémi Cardona
2012-09-16 1:45 ` Antti Palosaari
2012-09-16 1:26 ` [PATCH v2 0/6] ds3000 improvements Antti Palosaari
2012-09-17 12:54 ` Rémi Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50552BA5.1000000@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=remi.cardona@smartjog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).