From: Antti Palosaari <crope@iki.fi>
To: "Rémi Cardona" <remi.cardona@smartjog.com>
Cc: linux-media@vger.kernel.org, liplianin@me.by
Subject: Re: [PATCH 6/6] [media] ds3000: add module parameter to force firmware upload
Date: Sun, 16 Sep 2012 04:45:53 +0300 [thread overview]
Message-ID: <50552F51.6070406@iki.fi> (raw)
In-Reply-To: <1347614846-19046-7-git-send-email-remi.cardona@smartjog.com>
On 09/14/2012 12:27 PM, Rémi Cardona wrote:
> Signed-off-by: Rémi Cardona <remi.cardona@smartjog.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
With same comments as earlier patch.
> ---
> drivers/media/dvb/frontends/ds3000.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb/frontends/ds3000.c b/drivers/media/dvb/frontends/ds3000.c
> index 970963c..3e0e9de 100644
> --- a/drivers/media/dvb/frontends/ds3000.c
> +++ b/drivers/media/dvb/frontends/ds3000.c
> @@ -30,6 +30,7 @@
> #include "ds3000.h"
>
> static int debug;
> +static int force_fw_upload;
>
> #define dprintk(args...) \
> do { \
> @@ -396,10 +397,13 @@ static int ds3000_firmware_ondemand(struct dvb_frontend *fe)
> dprintk("%s()\n", __func__);
>
> ret = ds3000_readreg(state, 0xb2);
> - if (ret == 0) {
> + if (ret == 0 && force_fw_upload == 0) {
> printk(KERN_INFO "%s: Firmware already uploaded, skipping\n",
> __func__);
> return ret;
> + } else if (ret == 0 && force_fw_upload) {
> + printk(KERN_INFO "%s: Firmware already uploaded, "
> + "forcing upload\n", __func__);
> } else if (ret < 0) {
> return ret;
> }
> @@ -1308,6 +1312,9 @@ static struct dvb_frontend_ops ds3000_ops = {
> module_param(debug, int, 0644);
> MODULE_PARM_DESC(debug, "Activates frontend debugging (default:0)");
>
> +module_param(force_fw_upload, int, 0644);
> +MODULE_PARM_DESC(force_fw_upload, "Force firmware upload (default:0)");
> +
> MODULE_DESCRIPTION("DVB Frontend module for Montage Technology "
> "DS3000/TS2020 hardware");
> MODULE_AUTHOR("Konstantin Dimitrov");
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-09-16 1:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 9:27 [PATCH v2 0/6] ds3000 improvements Rémi Cardona
2012-09-14 9:27 ` [PATCH 1/6] [media] ds3000: Declare MODULE_FIRMWARE usage Rémi Cardona
2012-09-16 1:27 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 2/6] [media] ds3000: remove useless 'locking' Rémi Cardona
2012-09-16 1:28 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 3/6] [media] ds3000: properly report register read errors Rémi Cardona
2012-09-16 1:30 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 4/6] [media] ds3000: bail out early on i2c failures during firmware load Rémi Cardona
2012-09-16 1:41 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 5/6] [media] ds3000: properly report firmware probing issues Rémi Cardona
2012-09-16 1:44 ` Antti Palosaari
2012-09-14 9:27 ` [PATCH 6/6] [media] ds3000: add module parameter to force firmware upload Rémi Cardona
2012-09-16 1:45 ` Antti Palosaari [this message]
2012-09-16 1:26 ` [PATCH v2 0/6] ds3000 improvements Antti Palosaari
2012-09-17 12:54 ` Rémi Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50552F51.6070406@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=remi.cardona@smartjog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).