Re: [PATCH] [media] gscaler: mark it as BROKEN

[김승우 <sw0312.kim@samsung.com>]

Hi Mauro,

On 2012년 09월 16일 00:38, Mauro Carvalho Chehab wrote:
> -EMISSINGMAKEFILE
> 
> Without a Makefile, the driver will not compile, causing
> breakages for arm exynos5 sub-architecture.
> 
> Cc: Shaik Ameer Basha <shaik.ameer@samsung.com>
> Cc: Sungchun Kang <sungchun.kang@samsung.com>
> Cc: "Seung-Woo Kim/Mobile S/W Platform Lab(DMC)/E4"  <sw0312.kim@samsung.com>

Cc: Seung-Woo Kim <sw0312.kim@samsung.com> is enough, but it is not big
deal.

> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  drivers/media/platform/Kconfig  | 1 +
>  drivers/media/platform/Makefile | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 682594e..aa84d1d 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -184,6 +184,7 @@ config VIDEO_MX2_EMMAPRP
>  config VIDEO_SAMSUNG_EXYNOS_GSC
>  	tristate "Samsung Exynos G-Scaler driver"
>  	depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_EXYNOS5
> +	depends on BROKEN
>  	select VIDEOBUF2_DMA_CONTIG
>  	select V4L2_MEM2MEM_DEV
>  	help
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index baaa550..12d34c4 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -33,7 +33,9 @@ obj-$(CONFIG_VIDEO_SAMSUNG_S5P_MFC)	+= s5p-mfc/
>  obj-$(CONFIG_VIDEO_SAMSUNG_S5P_TV)	+= s5p-tv/
>  
>  obj-$(CONFIG_VIDEO_SAMSUNG_S5P_G2D)	+= s5p-g2d/
> -obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC)	+= exynos-gsc/
> +
> +# FIXME!!! This driver is broken, as there's no makefile there!
> +#obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC)	+= exynos-gsc/
>  
>  obj-$(CONFIG_BLACKFIN)                  += blackfin/
>  
> 

Thanks and Regards,
- Seung-Woo Kim

-- 
Seung-Woo Kim
Samsung Software R&D Center
--