* [PATCH] [media] gscaler: mark it as BROKEN
@ 2012-09-15 15:38 Mauro Carvalho Chehab
2012-09-17 2:19 ` 김승우
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2012-09-15 15:38 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Shaik Ameer Basha, Sungchun Kang,
Seung-Woo Kim/Mobile S/W Platform Lab(DMC)/E4, Kyungmin Park,
Sylwester Nawrocki
-EMISSINGMAKEFILE
Without a Makefile, the driver will not compile, causing
breakages for arm exynos5 sub-architecture.
Cc: Shaik Ameer Basha <shaik.ameer@samsung.com>
Cc: Sungchun Kang <sungchun.kang@samsung.com>
Cc: "Seung-Woo Kim/Mobile S/W Platform Lab(DMC)/E4" <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 682594e..aa84d1d 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -184,6 +184,7 @@ config VIDEO_MX2_EMMAPRP
config VIDEO_SAMSUNG_EXYNOS_GSC
tristate "Samsung Exynos G-Scaler driver"
depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_EXYNOS5
+ depends on BROKEN
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
help
diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
index baaa550..12d34c4 100644
--- a/drivers/media/platform/Makefile
+++ b/drivers/media/platform/Makefile
@@ -33,7 +33,9 @@ obj-$(CONFIG_VIDEO_SAMSUNG_S5P_MFC) += s5p-mfc/
obj-$(CONFIG_VIDEO_SAMSUNG_S5P_TV) += s5p-tv/
obj-$(CONFIG_VIDEO_SAMSUNG_S5P_G2D) += s5p-g2d/
-obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC) += exynos-gsc/
+
+# FIXME!!! This driver is broken, as there's no makefile there!
+#obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC) += exynos-gsc/
obj-$(CONFIG_BLACKFIN) += blackfin/
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] gscaler: mark it as BROKEN
2012-09-15 15:38 [PATCH] [media] gscaler: mark it as BROKEN Mauro Carvalho Chehab
@ 2012-09-17 2:19 ` 김승우
0 siblings, 0 replies; 2+ messages in thread
From: 김승우 @ 2012-09-17 2:19 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: sw0312.kim, Linux Media Mailing List, Shaik Ameer Basha,
Sungchun Kang, Kyungmin Park, Sylwester Nawrocki
Hi Mauro,
On 2012년 09월 16일 00:38, Mauro Carvalho Chehab wrote:
> -EMISSINGMAKEFILE
>
> Without a Makefile, the driver will not compile, causing
> breakages for arm exynos5 sub-architecture.
>
> Cc: Shaik Ameer Basha <shaik.ameer@samsung.com>
> Cc: Sungchun Kang <sungchun.kang@samsung.com>
> Cc: "Seung-Woo Kim/Mobile S/W Platform Lab(DMC)/E4" <sw0312.kim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com> is enough, but it is not big
deal.
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> drivers/media/platform/Kconfig | 1 +
> drivers/media/platform/Makefile | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 682594e..aa84d1d 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -184,6 +184,7 @@ config VIDEO_MX2_EMMAPRP
> config VIDEO_SAMSUNG_EXYNOS_GSC
> tristate "Samsung Exynos G-Scaler driver"
> depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_EXYNOS5
> + depends on BROKEN
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> help
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index baaa550..12d34c4 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -33,7 +33,9 @@ obj-$(CONFIG_VIDEO_SAMSUNG_S5P_MFC) += s5p-mfc/
> obj-$(CONFIG_VIDEO_SAMSUNG_S5P_TV) += s5p-tv/
>
> obj-$(CONFIG_VIDEO_SAMSUNG_S5P_G2D) += s5p-g2d/
> -obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC) += exynos-gsc/
> +
> +# FIXME!!! This driver is broken, as there's no makefile there!
> +#obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC) += exynos-gsc/
>
> obj-$(CONFIG_BLACKFIN) += blackfin/
>
>
Thanks and Regards,
- Seung-Woo Kim
--
Seung-Woo Kim
Samsung Software R&D Center
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-17 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-15 15:38 [PATCH] [media] gscaler: mark it as BROKEN Mauro Carvalho Chehab
2012-09-17 2:19 ` 김승우
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).