* [PATCH 0/3] Fix several warnings on new fc2580 tuner driver
@ 2012-09-24 11:37 Gianluca Gennari
2012-09-24 11:37 ` [PATCH 1/3] fc2580: define const as UL to silence a warning Gianluca Gennari
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Gianluca Gennari @ 2012-09-24 11:37 UTC (permalink / raw)
To: linux-media, crope; +Cc: mchehab, Gianluca Gennari
Hi all,
this small patch series fixes the warnings generated compiling the new fc2580
tuner driver on a Ubuntu system with the 2.6.32-43 32 bit kernel and GCC 4.4.3.
Compile tested only.
Best regards,
Gianluca Gennari
Gianluca Gennari (3):
fc2580: define const as UL to silence a warning
fc2580: silence uninitialized variable warning
fc2580: use macro for 64 bit division
drivers/media/tuners/fc2580.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] fc2580: define const as UL to silence a warning
2012-09-24 11:37 [PATCH 0/3] Fix several warnings on new fc2580 tuner driver Gianluca Gennari
@ 2012-09-24 11:37 ` Gianluca Gennari
2012-09-24 11:52 ` Antti Palosaari
2012-09-24 11:37 ` [PATCH 2/3] fc2580: silence uninitialized variable warning Gianluca Gennari
2012-09-24 11:37 ` [PATCH 3/3] fc2580: use macro for 64 bit division and reminder Gianluca Gennari
2 siblings, 1 reply; 7+ messages in thread
From: Gianluca Gennari @ 2012-09-24 11:37 UTC (permalink / raw)
To: linux-media, crope; +Cc: mchehab, Gianluca Gennari
fc2580.c: In function 'fc2580_set_params':
fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90
Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
drivers/media/tuners/fc2580.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
index afc0491..036e94b 100644
--- a/drivers/media/tuners/fc2580.c
+++ b/drivers/media/tuners/fc2580.c
@@ -147,7 +147,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
f_vco = c->frequency;
f_vco *= fc2580_pll_lut[i].div;
- if (f_vco >= 2600000000)
+ if (f_vco >= 2600000000UL)
tmp_val = 0x0e | fc2580_pll_lut[i].band;
else
tmp_val = 0x06 | fc2580_pll_lut[i].band;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] fc2580: silence uninitialized variable warning
2012-09-24 11:37 [PATCH 0/3] Fix several warnings on new fc2580 tuner driver Gianluca Gennari
2012-09-24 11:37 ` [PATCH 1/3] fc2580: define const as UL to silence a warning Gianluca Gennari
@ 2012-09-24 11:37 ` Gianluca Gennari
2012-09-24 11:55 ` Antti Palosaari
2012-09-24 11:37 ` [PATCH 3/3] fc2580: use macro for 64 bit division and reminder Gianluca Gennari
2 siblings, 1 reply; 7+ messages in thread
From: Gianluca Gennari @ 2012-09-24 11:37 UTC (permalink / raw)
To: linux-media, crope; +Cc: mchehab, Gianluca Gennari
fc2580.c: In function 'fc2580_set_params':
fc2580.c:118: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
drivers/media/tuners/fc2580.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
index 036e94b..3ad68e9 100644
--- a/drivers/media/tuners/fc2580.c
+++ b/drivers/media/tuners/fc2580.c
@@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
{
struct fc2580_priv *priv = fe->tuner_priv;
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
- int ret, i;
+ int ret=0, i;
unsigned int r_val, n_val, k_val, k_val_reg, f_ref;
u8 tmp_val, r18_val;
u64 f_vco;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] fc2580: use macro for 64 bit division and reminder
2012-09-24 11:37 [PATCH 0/3] Fix several warnings on new fc2580 tuner driver Gianluca Gennari
2012-09-24 11:37 ` [PATCH 1/3] fc2580: define const as UL to silence a warning Gianluca Gennari
2012-09-24 11:37 ` [PATCH 2/3] fc2580: silence uninitialized variable warning Gianluca Gennari
@ 2012-09-24 11:37 ` Gianluca Gennari
2012-09-24 11:55 ` Antti Palosaari
2 siblings, 1 reply; 7+ messages in thread
From: Gianluca Gennari @ 2012-09-24 11:37 UTC (permalink / raw)
To: linux-media, crope; +Cc: mchehab, Gianluca Gennari
Fixes the following warnings on a 32 bit system with GCC 4.4.3 and kernel Ubuntu 2.6.32-43 32 bit:
WARNING: "__udivdi3" [fc2580.ko] undefined!
WARNING: "__umoddi3" [fc2580.ko] undefined!
Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
drivers/media/tuners/fc2580.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
index 3ad68e9..2e8ebac 100644
--- a/drivers/media/tuners/fc2580.c
+++ b/drivers/media/tuners/fc2580.c
@@ -168,8 +168,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
}
f_ref = 2UL * priv->cfg->clock / r_val;
- n_val = f_vco / f_ref;
- k_val = f_vco % f_ref;
+ n_val = div_u64_rem(f_vco, f_ref, &k_val);
k_val_reg = 1UL * k_val * (1 << 20) / f_ref;
ret = fc2580_wr_reg(priv, 0x18, r18_val | ((k_val_reg >> 16) & 0xff));
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] fc2580: define const as UL to silence a warning
2012-09-24 11:37 ` [PATCH 1/3] fc2580: define const as UL to silence a warning Gianluca Gennari
@ 2012-09-24 11:52 ` Antti Palosaari
0 siblings, 0 replies; 7+ messages in thread
From: Antti Palosaari @ 2012-09-24 11:52 UTC (permalink / raw)
To: Gianluca Gennari; +Cc: linux-media, mchehab
On 09/24/2012 02:37 PM, Gianluca Gennari wrote:
> fc2580.c: In function 'fc2580_set_params':
> fc2580.c:150: warning: this decimal constant is unsigned only in ISO C90
>
> Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/tuners/fc2580.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index afc0491..036e94b 100644
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -147,7 +147,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
> f_vco = c->frequency;
> f_vco *= fc2580_pll_lut[i].div;
>
> - if (f_vco >= 2600000000)
> + if (f_vco >= 2600000000UL)
> tmp_val = 0x0e | fc2580_pll_lut[i].band;
> else
> tmp_val = 0x06 | fc2580_pll_lut[i].band;
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] fc2580: silence uninitialized variable warning
2012-09-24 11:37 ` [PATCH 2/3] fc2580: silence uninitialized variable warning Gianluca Gennari
@ 2012-09-24 11:55 ` Antti Palosaari
0 siblings, 0 replies; 7+ messages in thread
From: Antti Palosaari @ 2012-09-24 11:55 UTC (permalink / raw)
To: Gianluca Gennari; +Cc: linux-media, mchehab
On 09/24/2012 02:37 PM, Gianluca Gennari wrote:
> fc2580.c: In function 'fc2580_set_params':
> fc2580.c:118: warning: 'ret' may be used uninitialized in this function
>
> Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
> ---
> drivers/media/tuners/fc2580.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index 036e94b..3ad68e9 100644
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
> {
> struct fc2580_priv *priv = fe->tuner_priv;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> - int ret, i;
> + int ret=0, i;
Nack. This is Codingstyle violation. See rules around line 206 from
Documentation/CodingStyle
That replace warning with Codingstyle mistake. Change it to meet
CodingStyle and resend.
> unsigned int r_val, n_val, k_val, k_val_reg, f_ref;
> u8 tmp_val, r18_val;
> u64 f_vco;
>
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] fc2580: use macro for 64 bit division and reminder
2012-09-24 11:37 ` [PATCH 3/3] fc2580: use macro for 64 bit division and reminder Gianluca Gennari
@ 2012-09-24 11:55 ` Antti Palosaari
0 siblings, 0 replies; 7+ messages in thread
From: Antti Palosaari @ 2012-09-24 11:55 UTC (permalink / raw)
To: Gianluca Gennari; +Cc: linux-media, mchehab
On 09/24/2012 02:37 PM, Gianluca Gennari wrote:
> Fixes the following warnings on a 32 bit system with GCC 4.4.3 and kernel Ubuntu 2.6.32-43 32 bit:
>
> WARNING: "__udivdi3" [fc2580.ko] undefined!
> WARNING: "__umoddi3" [fc2580.ko] undefined!
>
> Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/tuners/fc2580.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index 3ad68e9..2e8ebac 100644
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -168,8 +168,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
> }
>
> f_ref = 2UL * priv->cfg->clock / r_val;
> - n_val = f_vco / f_ref;
> - k_val = f_vco % f_ref;
> + n_val = div_u64_rem(f_vco, f_ref, &k_val);
> k_val_reg = 1UL * k_val * (1 << 20) / f_ref;
>
> ret = fc2580_wr_reg(priv, 0x18, r18_val | ((k_val_reg >> 16) & 0xff));
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-24 11:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24 11:37 [PATCH 0/3] Fix several warnings on new fc2580 tuner driver Gianluca Gennari
2012-09-24 11:37 ` [PATCH 1/3] fc2580: define const as UL to silence a warning Gianluca Gennari
2012-09-24 11:52 ` Antti Palosaari
2012-09-24 11:37 ` [PATCH 2/3] fc2580: silence uninitialized variable warning Gianluca Gennari
2012-09-24 11:55 ` Antti Palosaari
2012-09-24 11:37 ` [PATCH 3/3] fc2580: use macro for 64 bit division and reminder Gianluca Gennari
2012-09-24 11:55 ` Antti Palosaari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).