From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, a.hajda@samsung.com,
sakari.ailus@iki.fi, hverkuil@xs4all.nl,
kyungmin.park@samsung.com, sw0312.kim@samsung.com
Subject: Re: [PATCH RFC 2/5] V4L: Add V4L2_PIX_FMT_S5C_UYVY_JPG fourcc definition
Date: Tue, 25 Sep 2012 16:47:59 +0200 [thread overview]
Message-ID: <5061C41F.6080100@samsung.com> (raw)
In-Reply-To: <2113003.Cq6nRq7Zuu@avalon>
Hi Laurent,
On 09/25/2012 01:44 PM, Laurent Pinchart wrote:
>> diff --git a/Documentation/DocBook/media/v4l/pixfmt.xml
>> b/Documentation/DocBook/media/v4l/pixfmt.xml index 1ddbfab..9caed9b 100644
>> --- a/Documentation/DocBook/media/v4l/pixfmt.xml
>> +++ b/Documentation/DocBook/media/v4l/pixfmt.xml
>> @@ -996,6 +996,15 @@ the other bits are set to 0.</entry>
>> <entry>Old 6-bit greyscale format. Only the most significant 6 bits
> of
>> each byte are used, the other bits are set to 0.</entry>
>> </row>
>> + <row id="V4L2-PIX-FMT-JPG-YUYV-S5C">
>> + <entry><constant>V4L2_PIX_FMT_S5C_YUYV_JPG</constant></entry>
>> + <entry>'S5CJ'</entry>
>> + <entry>Two-planar format used by Samsung S5C73MX cameras.The first
>> +plane contains interleaved JPEG and YUYV data, followed by meta data
>> describing +layout of the YUYV and JPEG data blocks. The second plane
>> contains additional +information about data layout in the first plane, like
>> an offset to the array +of offsets to YUVY data chunks.</entry>
>> + </row>
>
> I think you need to be a bit more precise here. You should document the format
> of the meta data, as that's required for applications to use the format.
Right, I wasn't sure how detailed this DocBook description should be.
I thought about adding more detailed explanation of this format under
Documentation/video4linux/, but it probably makes more sense to add
a few more sentences here and make it complete and really useful.
Let me correct that in the next iteration.
Regards,
Sylwester
next prev parent reply other threads:[~2012-09-25 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:55 [PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format Sylwester Nawrocki
2012-09-25 11:42 ` Laurent Pinchart
2012-09-25 14:39 ` Sylwester Nawrocki
2012-10-09 13:36 ` Vincent ABRIOU
2012-10-09 17:09 ` Sylwester Nawrocki
2012-10-15 18:35 ` Sakari Ailus
2012-11-06 10:02 ` Vincent ABRIOU
2012-09-24 14:55 ` [PATCH RFC 2/5] V4L: Add V4L2_PIX_FMT_S5C_UYVY_JPG fourcc definition Sylwester Nawrocki
2012-09-25 11:44 ` Laurent Pinchart
2012-09-25 14:47 ` Sylwester Nawrocki [this message]
2012-09-24 14:55 ` [PATCH RFC 3/5] s5p-csis: Add support for non-image data packets capture Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 4/5] s5p-fimc: Add support for V4L2_PIX_FMT_S5C_UYVY_JPG fourcc Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 5/5] m5mols: Implement .get_frame_desc subdev callback Sylwester Nawrocki
2012-09-24 15:10 ` [PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support Sylwester Nawrocki
2012-09-25 11:37 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5061C41F.6080100@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).