* [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion @ 2012-09-26 7:18 Sachin Kamat 2012-09-26 7:18 ` [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers Sachin Kamat 2012-09-26 9:06 ` [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sylwester Nawrocki 0 siblings, 2 replies; 3+ messages in thread From: Sachin Kamat @ 2012-09-26 7:18 UTC (permalink / raw) To: linux-media; +Cc: s.nawrocki, shaik.ameer, sachin.kamat, patches version.h is not needed for these files. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/media/platform/exynos-gsc/gsc-core.c | 1 - drivers/media/platform/exynos-gsc/gsc-m2m.c | 1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index c5c7625..90a6c55 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -12,7 +12,6 @@ #include <linux/module.h> #include <linux/kernel.h> -#include <linux/version.h> #include <linux/types.h> #include <linux/errno.h> #include <linux/bug.h> diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index 2589cae..a4f327e 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -12,7 +12,6 @@ #include <linux/module.h> #include <linux/kernel.h> -#include <linux/version.h> #include <linux/types.h> #include <linux/errno.h> #include <linux/bug.h> -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers 2012-09-26 7:18 [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sachin Kamat @ 2012-09-26 7:18 ` Sachin Kamat 2012-09-26 9:06 ` [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sylwester Nawrocki 1 sibling, 0 replies; 3+ messages in thread From: Sachin Kamat @ 2012-09-26 7:18 UTC (permalink / raw) To: linux-media; +Cc: s.nawrocki, shaik.ameer, sachin.kamat, patches Fixes the following warnings: drivers/media/platform/exynos-gsc/gsc-core.c:313:5: warning: symbol 'get_plane_info' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-core.c:746:28: warning: symbol 'gsc_ctrl_ops' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:102:5: warning: symbol 'gsc_fill_addr' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:252:16: warning: symbol 'gsc_m2m_qops' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 90a6c55..bfec9e6 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -310,7 +310,7 @@ int gsc_enum_fmt_mplane(struct v4l2_fmtdesc *f) return 0; } -u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) +static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) { if (frm->addr.y == addr) { *index = 0; @@ -743,7 +743,7 @@ static int gsc_s_ctrl(struct v4l2_ctrl *ctrl) return ret; } -const struct v4l2_ctrl_ops gsc_ctrl_ops = { +static const struct v4l2_ctrl_ops gsc_ctrl_ops = { .s_ctrl = gsc_s_ctrl, }; diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index a4f327e..3c7f005 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -99,7 +99,7 @@ static void gsc_m2m_job_abort(void *priv) gsc_m2m_job_finish(ctx, VB2_BUF_STATE_ERROR); } -int gsc_fill_addr(struct gsc_ctx *ctx) +static int gsc_fill_addr(struct gsc_ctx *ctx) { struct gsc_frame *s_frame, *d_frame; struct vb2_buffer *vb = NULL; @@ -249,7 +249,7 @@ static void gsc_m2m_buf_queue(struct vb2_buffer *vb) v4l2_m2m_buf_queue(ctx->m2m_ctx, vb); } -struct vb2_ops gsc_m2m_qops = { +static struct vb2_ops gsc_m2m_qops = { .queue_setup = gsc_m2m_queue_setup, .buf_prepare = gsc_m2m_buf_prepare, .buf_queue = gsc_m2m_buf_queue, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion 2012-09-26 7:18 [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sachin Kamat 2012-09-26 7:18 ` [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers Sachin Kamat @ 2012-09-26 9:06 ` Sylwester Nawrocki 1 sibling, 0 replies; 3+ messages in thread From: Sylwester Nawrocki @ 2012-09-26 9:06 UTC (permalink / raw) To: Sachin Kamat; +Cc: linux-media, shaik.ameer, patches On 09/26/2012 09:18 AM, Sachin Kamat wrote: > version.h is not needed for these files. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Applied both, thank you. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-26 9:07 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-26 7:18 [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sachin Kamat 2012-09-26 7:18 ` [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers Sachin Kamat 2012-09-26 9:06 ` [PATCH 1/2] [media] exynos-gsc: Remove <linux/version.h> header file inclusion Sylwester Nawrocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).