From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:52629 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578Ab2I0T7t (ORCPT ); Thu, 27 Sep 2012 15:59:49 -0400 Message-ID: <5064B01E.4070802@iki.fi> Date: Thu, 27 Sep 2012 22:59:26 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Michael Krufky , linux-media Subject: Re: tda18271 driver power consumption References: <500C5B9B.8000303@iki.fi> <500F1DC5.1000608@iki.fi> <500F4140.1000202@iki.fi> <20120927161940.0f673e2e@redhat.com> In-Reply-To: <20120927161940.0f673e2e@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/27/2012 10:19 PM, Mauro Carvalho Chehab wrote: > Em Thu, 26 Jul 2012 08:48:58 -0400 > Michael Krufky escreveu: > >> Antti, >> >> This small patch should do the trick -- can you test it? >> >> >> The following changes since commit 0c7d5a6da75caecc677be1fda207b7578936770d: >> >> Linux 3.5-rc5 (2012-07-03 22:57:41 +0300) >> >> are available in the git repository at: >> >> git://git.linuxtv.org/mkrufky/tuners tda18271 >> >> for you to fetch changes up to 782b28e20d3b253d317cc71879639bf3c108b200: >> >> tda18271: enter low-power standby mode at the end of >> tda18271_attach() (2012-07-26 08:34:37 -0400) >> >> ---------------------------------------------------------------- >> Michael Krufky (1): >> tda18271: enter low-power standby mode at the end of tda18271_attach() >> >> drivers/media/common/tuners/tda18271-fe.c | 3 +++ >> 1 file changed, 3 insertions(+) > > > Mike, > > Despite patchwork's way of handling, thinking that this is a pull request, > I suspect that your intention here were simply offer some patches for Antti > to test. > > In any case, please always send the patches via email to the ML before > sending a pull request. This was always a rule, but some developers are > lazy with this duty, and, as I didn't use to have a tool to double check, > bad things happen. > > I'm now finally able to check with a simple script if weather a patch > went to the ML or not. My script checks both reply-to/references email > tags and it looks for the same patch subject at the ML Inbox. > So, I'll be now be more grumpy with that ;) [1] > > So, please be sure to post those patches at the ML, with Antti's tested-by: > tag, before sending a pull request. > > Thanks! > Mauro > > [1] Side note: it is not actually a matter of being grumpy; posted patches > receive a lot more attention/review than simple pull requests. From time > to time, patches that went via the wrong way (e. g. without a previous post) > caused troubles for other developers. So, enforcing it is actually a matter > of improving Kernel quality and avoiding regressions. > > - > > $ test_patch > testing if patches/0001-tda18271-enter-low-power-standby-mode-at-the-end-of-.patch applies > patch -p1 -i patches/0001-tda18271-enter-low-power-standby-mode-at-the-end-of-.patch --dry-run -t -N > patching file drivers/media/tuners/tda18271-fe.c > drivers/media/tuners/tda18271-fe.c | 3 +++ > 1 file changed, 3 insertions(+) > Subject: tda18271: enter low-power standby mode at the end of tda18271_attach() > From: Michael Krufky > Date: Thu, 26 Jul 2012 08:34:37 -0400 > Patch applies OK > total: 0 errors, 0 warnings, 9 lines checked > > patches/0001-tda18271-enter-low-power-standby-mode-at-the-end-of-.patch has no obvious style problems and is ready for submission. > Didn't find any message with subject equal to 'tda18271: enter low-power standby mode at the end of tda18271_attach()' > Duplicated md5sum patches > Likely duplicated patches (need manual check) If that tda18271 patch is not applied then these two should be: https://patchwork.kernel.org/patch/1481901/ https://patchwork.kernel.org/patch/1481911/ regards Antti -- http://palosaari.fi/