From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Ezequiel Garcia <elezegarcia@gmail.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Antti Palosaari <crope@iki.fi>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>
Subject: Re: [GIT PATCHES FOR v3.6] Samsung media driver fixes
Date: Mon, 01 Oct 2012 16:44:59 +0200 [thread overview]
Message-ID: <5069AC6B.80902@samsung.com> (raw)
In-Reply-To: <201210011628.36850.hverkuil@xs4all.nl>
On 10/01/2012 04:28 PM, Hans Verkuil wrote:
> On Mon October 1 2012 16:05:15 Ezequiel Garcia wrote:
>> Mauro and folks,
>>
>> On Mon, Oct 1, 2012 at 10:35 AM, Mauro Carvalho Chehab
>> <mchehab@redhat.com> wrote:
>>> Hi Anti/Sylwester,
>>>
>>> Em 01-10-2012 08:50, Antti Palosaari escreveu:
>>>> Hello
>>>> I have had similar problems too. We need badly find out better procedures for patch handling. Something like parches are updated about once per week to the master. I have found I lose quite much time rebasing and res-sending stuff all the time.
>>>>
>>>> What I propose:
>>>> 1) module maintainers sends all patches to the ML with some tag marking it will pull requested later. I used lately [PATCH RFC]
>>>> 2) module maintainer will pick up all the "random" patches and pull request those. There is no way to mark patch as handled in patchwork....
>>>> 3) PULL request are handled more often, like during one week or maximum two
>>>
>>> Yes, for sure we need to improve the workflow. After the return from KS,
>>> I found ~400 patches/pull requests on my queue. I'm working hard to get rid
>>> of that backlog, but still there are ~270 patches/pull requests on my
>>> queue today.
>>>
>>> The thing is that patches come on a high rate at the ML, and there's no
>>> obvious way to discover what patches are just the normal patch review
>>> discussions (e. g. RFC) and what are real patches.
>>>
>>> To make things worse, we have nowadays 494 drivers. A very few of those
>>> have an entry at MAINTAINERS, or a maintainer that care enough about
>>> his drivers to handle patches sent to the mailing list (even the trivial
>>> ones).
>>>
>>> Due to the missing MAINTAINERS entries, all patches go through the ML directly,
>>> instead of going through the driver maintainer.
>>>
>>> So, I need to manually review every single email that looks to have a patch
>>> inside, typically forwarding it to the driver maintainer, when it exists,
>>> handling them myself otherwise.
>>>
>>> I'm counting with our discussions at the Barcelona's mini-summit in order
>>> to be able to get fresh ideas and discuss some alternatives to improve
>>> the patch workflow, but there are several things that could be done already,
>>> like the ones you've proposed, and keeping the MAINTAINERS file updated.
>>>
>>
>> Perhaps I'm missing something but I don't think there's an obvious
>> solution for this,
>> unless more maintainers are willing to start providing reviews / tests
>> / acks / etc.
>> for patches that arrive.
>>
>> Seems to me media/ has become a truly large subsystem,
>> though I'm not sure how does it compare to others subsystems.
>> Has anyone thought about breaking media/ down into smaller sub-subsystems,
>> with respective sub-maintainer?
>
> Yes, and this will be discussed next month during the Media Summit.
Something like this came through my mind as well. It seems handling all
the drivers/media stuff is becoming simply too much to tackle by one person
in quality and timely manner.
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-10-01 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 8:32 [GIT PATCHES FOR v3.6] Samsung media driver fixes Sylwester Nawrocki
2012-09-05 16:12 ` Sylwester Nawrocki
2012-10-01 9:52 ` Sylwester Nawrocki
2012-10-01 11:50 ` Antti Palosaari
2012-10-01 13:35 ` Mauro Carvalho Chehab
2012-10-01 14:05 ` Ezequiel Garcia
2012-10-01 14:28 ` Hans Verkuil
2012-10-01 14:44 ` Sylwester Nawrocki [this message]
2012-10-01 14:48 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069AC6B.80902@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=crope@iki.fi \
--cc=elezegarcia@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).