Re: The em28xx driver error

["Frank Schäfer" <fschaefer.oss@googlemail.com>]

Am 15.11.2012 17:35, schrieb Devin Heitmueller:
> On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer
> <fschaefer.oss@googlemail.com> wrote:
>> Hmm... I've made some experiments to find out what gcc does on x86 and
>> it seems to ignore bit shifting > 32.
>> I also noticed that this line has been removed in 3.7-rc.
>> So we do NOT want to halve the height for interlaced devices here, right ?
> Even with the datasheets, it was never clear to me what role the
> accumulator size played.  It appeared to work regardless of whether it
> was halved (although making it zero obviously caused problems).
>
> Hence, since we couldn't see any visible difference, Mauro just
> removed the code.  My guess is that it effects the on-chip internal
> buffering hence it's possible that performance/reliability could be
> effected under extreme load or some edge case, but I don't have any
> data to back up that assertion at this time.
>
> Devin
>
Interesting.
As the buggy line seemed to have no effect on x86 and the driver was
working fine, it makes indeed sense to stay with the full height to
avoid regressions.

Regards,
Frank