From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, patches@linaro.org,
Shaik Ameer Basha <shaik.ameer@samsung.com>
Subject: Re: [PATCH 1/4] [media] exynos-gsc: Rearrange error messages for valid prints
Date: Fri, 23 Nov 2012 10:58:54 +0100 [thread overview]
Message-ID: <50AF48DE.8080501@samsung.com> (raw)
In-Reply-To: <CAK9yfHzOs6B0=Z+EwwGt670tNLkpvFX0nkVELMzyyikpgzY=cw@mail.gmail.com>
On 11/23/2012 10:47 AM, Sachin Kamat wrote:
>>> +err_clk_prepare:
>>> gsc_clk_put(gsc);
>>
>> This call can be removed too. I would remove all labels and gotos in
>> this function. Since there is only one clock, you need to only call
>> clk_put when clk_prepare() fails, there is no need for gsc_clk_put().
>
> I have removed gsc_clk_put() in the subsequent patch in this series.
> I will probably incorporate your previous comment and remove the label
> altogether (in patch 3) and send it again.
OK, sounds good to me that way too.
next prev parent reply other threads:[~2012-11-23 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 4:44 [PATCH 0/4] [media] exynos-gsc: Some fixes Sachin Kamat
2012-11-23 4:44 ` [PATCH 1/4] [media] exynos-gsc: Rearrange error messages for valid prints Sachin Kamat
2012-11-23 9:31 ` Sylwester Nawrocki
2012-11-23 9:47 ` Sachin Kamat
2012-11-23 9:58 ` Sylwester Nawrocki [this message]
2012-11-23 4:45 ` [PATCH 2/4] [media] exynos-gsc: Remove gsc_clk_put call from gsc_clk_get Sachin Kamat
2012-11-23 9:51 ` Sylwester Nawrocki
2012-11-23 4:45 ` [PATCH 3/4] [media] exynos-gsc: Use devm_clk_get() Sachin Kamat
2012-11-23 4:45 ` [PATCH 4/4] [media] exynos-gsc: Fix checkpatch warning in gsc-m2m.c Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AF48DE.8080501@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=shaik.ameer@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox