Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hello,

On 11/27/2012 8:39 AM, Prabhakar Lad wrote:
> Hi Marek,
>
> On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> > Hello,
> >
> >
> > On 11/27/2012 6:59 AM, Prabhakar Lad wrote:
> >>
> >> From: Lad, Prabhakar <prabhakar.lad@ti.com>
> >>
> >> from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds
> >> a check HAVE_GENERIC_DMA_COHERENT for dma ops, the check was wrongly
> >> made it should have been HAVE_GENERIC_DMA_COHERENT but it was
> >> CONFIG_HAVE_GENERIC_DMA_COHERENT.
> >> This patch fixes the typo, which was causing following build error:
> >>
> >> videobuf2-dma-contig.c:743: error: 'vb2_dc_get_dmabuf' undeclared here
> >> (not in a function)
> >> make[3]: *** [drivers/media/v4l2-core/videobuf2-dma-contig.o] Error 1
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> >> Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> >
> >
> > The CONFIG_HAVE_GENERIC_DMA_COHERENT based patch was a quick workaround
> > for the build problem in linux-next and should be reverted now. The
> > correct patch has been posted for drivers/base/dma-mapping.c to LKML,
> > see http://www.spinics.net/lists/linux-next/msg22890.html
>
> I was referring to this patch from Mauro,
> http://git.linuxtv.org/media_tree.git/commitdiff/93049b9368a2e257ace66252ab2cc066f3399cad
> which introduced this build error.

I know, with my patch the workaround introduced by Mauro is not needed 
at all.

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center