From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 0/9] em28xx: refactor the frame data processing code
Date: Fri, 14 Dec 2012 16:45:03 +0100 [thread overview]
Message-ID: <50CB497F.6070803@googlemail.com> (raw)
In-Reply-To: <CAGoCfixTeu6m0dcmpy7p=_BM8oZknCwyJ=jFPPM7bgJKC=-=jg@mail.gmail.com>
Am 14.12.2012 16:29, schrieb Devin Heitmueller:
>>>> Yes, there will likely be heavy merge conflicts...
>>>> In which tree are the videobuf2 patches ?
>>> It's in a private tree right now, and it doesn't support VBI
>>> currently. Once I've setup a public tree with yours and Hans changes,
>>> I'll start merging in my changes.
>> I suggest to do the conversion on top of my patches, as they should make
>> things much easier for you.
>> I unified the handling of the VBI and video buffers, leaving just a few
>> common functions dealing with the videobuf stuff.
> Yup, that's exactly what I had planned.
>
>> In any case, we should develop against a common tree with a minimum
>> number of pending patches.
>> And we should coordinate development.
>> I don't work on further changes of the frame processing stuff at the moment.
>> Some I2C fixes/changes will be next. After that, I will try to fix
>> support for remote controls with external IR IC (connected via i2c).
>>
>>> Obviously it would be great for you to test with your webcam and make
>>> sure I didn't break anything along the way.
>> Sure, I will be glad to test your changes.
>>
>>> I've also got changes to support V4L2_FIELD_SEQ_TB, which is needed in
>>> order to take the output and feed to certain hardware deinterlacers.
>>> In reality this is pretty much just a matter of treating the video
>>> data as progressive but changing the field type indicator.
>> Ok, so I assume most of the changes will happen in em28xx_copy_video().
> The changes really are all over the tree because it's not just vb2
> support but also support for v4l2_fh, which means every ioctl() has a
> change to its arguments, and there is no longer an open/close call
> implemented. Also significant impact on the locking model.
Ok. Sounds like a lot of fun... ;)
If the changes are all over the tree, we will likely get more collisions.
So we should both make our changes public as soon as possible.
>
>> Maybe we can then use a common copy function for video and VBI. Placing
>> the field data sequentially in the videobuf is what we already do with
>> the VBI data in em28xx_copy_vbi()
> Let's get something that works, at which point we can tune/optimize as needed.
I agree.
Frank
>
> Devin
>
> --
> Devin J. Heitmueller - Kernel Labs
> http://www.kernellabs.com
prev parent reply other threads:[~2012-12-14 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 15:31 [PATCH 0/9] em28xx: refactor the frame data processing code Frank Schäfer
2012-12-08 15:31 ` [PATCH 1/9] em28xx: refactor get_next_buf() and use it for vbi data, too Frank Schäfer
2012-12-08 15:31 ` [PATCH 2/9] em28xx: use common function for video and vbi buffer completion Frank Schäfer
2012-12-08 15:31 ` [PATCH 3/9] em28xx: remove obsolete field 'frame' from struct em28xx_buffer Frank Schäfer
2012-12-08 15:31 ` [PATCH 4/9] em28xx: move field 'pos' from struct em28xx_dmaqueue to " Frank Schäfer
2012-12-08 15:31 ` [PATCH 5/9] em28xx: refactor VBI data processing code in em28xx_urb_data_copy() Frank Schäfer
2012-12-08 15:31 ` [PATCH 6/9] em28xx: move caching of pointer to vmalloc memory in videobuf to struct em28xx_buffer Frank Schäfer
2012-12-08 15:31 ` [PATCH 7/9] em28xx: em28xx_urb_data_copy(): move duplicate code for capture_type=0 and capture_type=2 to a function Frank Schäfer
2012-12-08 15:31 ` [PATCH 8/9] em28xx: move the em2710/em2750/em28xx specific frame data processing code to a separate function Frank Schäfer
2012-12-08 15:31 ` [PATCH 9/9] em28xx: clean up and unify functions em28xx_copy_vbi() em28xx_copy_video() Frank Schäfer
[not found] ` <CAGoCfiw1wN+KgvNLqDSmbz5AwswPT9K48XOM4RnfKvHkmmR59g@mail.gmail.com>
2012-12-13 17:56 ` [PATCH 0/9] em28xx: refactor the frame data processing code Frank Schäfer
2012-12-13 18:16 ` Devin Heitmueller
2012-12-14 15:24 ` Frank Schäfer
2012-12-14 15:29 ` Devin Heitmueller
2012-12-14 15:45 ` Frank Schäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB497F.6070803@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).