* Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)
@ 2012-12-13 17:53 Frank Schäfer
2012-12-13 20:43 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Frank Schäfer @ 2012-12-13 17:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: remy.blank, Linux Media Mailing List, Devin Heitmueller
Hi Mauro,
could you please take a look at kernel bug 14126
(https://bugzilla.kernel.org/show_bug.cgi?id=14126) ?
The bug reporter posted a patch 3 years ago (!), which seems to be valid.
As mentioned in an earlier post, I've got a Cinergy 200 USB recently and
tried to figure out the difference between both devices:
Common:
- handbook / product description from Terratec seems to be completely
identical (except that the number 200 is replaced with 250)
- both devices are looking identical
- Empia bridge
- saa7113
- tda9887
- remote control with external i2c IR IC
- physical connectors*: antenna, line-in and line-out (stereo jack), SVIDEO
(*: some pictures show an additional connector on the side, but at least
Remys' and my device don't have it).
Cinergy 200 USB (my device):
- generic USB ID: eb1a:2800
- em2800
- no eeprom
- no AC97 IC
- LG TALN (tuner 66)
- audio over USB doesn't work
- audio line-in is shortcut with line-out
Cinergy 250 USB (Remy's device):
- unique USB ID: 0ccd:0036
- em2820
- eeprom
- Empia 202 AC97
- LG TAPC (tuner 37)
- audio over USB works (from both, tuner and line-in)
In the em28xx driver, we currently have the following board definitions:
[EM2800_BOARD_TERRATEC_CINERGY_200] = {
.name = "Terratec Cinergy 200 USB",
.is_em2800 = 1,
.has_ir_i2c = 1,
.tuner_type = TUNER_LG_TALN,
.tda9887_conf = TDA9887_PRESENT,
.decoder = EM28XX_SAA711X,
.input = { {
.type = EM28XX_VMUX_TELEVISION,
.vmux = SAA7115_COMPOSITE2,
.amux = EM28XX_AMUX_VIDEO,
}, {
.type = EM28XX_VMUX_COMPOSITE1,
.vmux = SAA7115_COMPOSITE0,
.amux = EM28XX_AMUX_LINE_IN,
}, {
.type = EM28XX_VMUX_SVIDEO,
.vmux = SAA7115_SVIDEO3,
.amux = EM28XX_AMUX_LINE_IN,
} },
},
[EM2820_BOARD_TERRATEC_CINERGY_250] = {
.name = "Terratec Cinergy 250 USB",
.tuner_type = TUNER_LG_PAL_NEW_TAPC,
.has_ir_i2c = 1,
.tda9887_conf = TDA9887_PRESENT,
.decoder = EM28XX_SAA711X,
.input = { {
.type = EM28XX_VMUX_TELEVISION,
.vmux = SAA7115_COMPOSITE2,
.amux = EM28XX_AMUX_LINE_IN,
}, {
.type = EM28XX_VMUX_COMPOSITE1,
.vmux = SAA7115_COMPOSITE0,
.amux = EM28XX_AMUX_LINE_IN,
}, {
.type = EM28XX_VMUX_SVIDEO,
.vmux = SAA7115_SVIDEO3,
.amux = EM28XX_AMUX_LINE_IN,
} },
},
Remy wants to change .amux for TV input from EM28XX_AMUX_LINE_IN to
EM28XX_AMUX_VIDEO, which makes sense for the device he has.
For my Cinergy 200, neither EM28XX_AMUX_VIDEO nor EM28XX_AMUX_LINE_IN
works, because it misses an AC97 IC.
Another question is, if we should remove the COMPOSITE input. At least
Remys' and my device use a COMPOSITE to SVIDEO adapter cable.
The big question is now, if we can be sure that there are no other
device variants, for which the current board definitions are right.
Especially because of the pictures with the additional connector on the
side...
But these pictures are all product pictures from Terratec, no one knows
if they have ever been sold...
So I'll leave it up to you to decide, which changes to make. :D
But it's definitely time to close this old bug report. ;)
Regards,
Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)
2012-12-13 17:53 Bug 14126 (em28xx, Terratec Cinergy 200/250 USB) Frank Schäfer
@ 2012-12-13 20:43 ` Mauro Carvalho Chehab
2013-01-03 18:01 ` Frank Schäfer
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2012-12-13 20:43 UTC (permalink / raw)
To: Frank Schäfer
Cc: remy.blank, Linux Media Mailing List, Devin Heitmueller,
Sascha Sommer
Hi Frank,
Em Thu, 13 Dec 2012 18:53:46 +0100
Frank Schäfer <fschaefer.oss@googlemail.com> escreveu:
> Hi Mauro,
>
> could you please take a look at kernel bug 14126
> (https://bugzilla.kernel.org/show_bug.cgi?id=14126) ?
> The bug reporter posted a patch 3 years ago (!), which seems to be valid.
>
> As mentioned in an earlier post, I've got a Cinergy 200 USB recently and
> tried to figure out the difference between both devices:
>
> Common:
> - handbook / product description from Terratec seems to be completely
> identical (except that the number 200 is replaced with 250)
> - both devices are looking identical
> - Empia bridge
> - saa7113
> - tda9887
> - remote control with external i2c IR IC
> - physical connectors*: antenna, line-in and line-out (stereo jack), SVIDEO
>
> (*: some pictures show an additional connector on the side, but at least
> Remys' and my device don't have it).
Likely, some device variant. The driver should keep support for it, to avoid
breaking support for those variants.
>
> Cinergy 200 USB (my device):
> - generic USB ID: eb1a:2800
> - em2800
> - no eeprom
> - no AC97 IC
> - LG TALN (tuner 66)
> - audio over USB doesn't work
> - audio line-in is shortcut with line-out
>
> Cinergy 250 USB (Remy's device):
> - unique USB ID: 0ccd:0036
> - em2820
> - eeprom
> - Empia 202 AC97
> - LG TAPC (tuner 37)
> - audio over USB works (from both, tuner and line-in)
>
>
>
> In the em28xx driver, we currently have the following board definitions:
>
> [EM2800_BOARD_TERRATEC_CINERGY_200] = {
> .name = "Terratec Cinergy 200 USB",
> .is_em2800 = 1,
> .has_ir_i2c = 1,
> .tuner_type = TUNER_LG_TALN,
> .tda9887_conf = TDA9887_PRESENT,
> .decoder = EM28XX_SAA711X,
> .input = { {
> .type = EM28XX_VMUX_TELEVISION,
> .vmux = SAA7115_COMPOSITE2,
> .amux = EM28XX_AMUX_VIDEO,
> }, {
> .type = EM28XX_VMUX_COMPOSITE1,
> .vmux = SAA7115_COMPOSITE0,
> .amux = EM28XX_AMUX_LINE_IN,
> }, {
> .type = EM28XX_VMUX_SVIDEO,
> .vmux = SAA7115_SVIDEO3,
> .amux = EM28XX_AMUX_LINE_IN,
> } },
> },
>
>
> [EM2820_BOARD_TERRATEC_CINERGY_250] = {
> .name = "Terratec Cinergy 250 USB",
> .tuner_type = TUNER_LG_PAL_NEW_TAPC,
> .has_ir_i2c = 1,
> .tda9887_conf = TDA9887_PRESENT,
> .decoder = EM28XX_SAA711X,
> .input = { {
> .type = EM28XX_VMUX_TELEVISION,
> .vmux = SAA7115_COMPOSITE2,
> .amux = EM28XX_AMUX_LINE_IN,
> }, {
> .type = EM28XX_VMUX_COMPOSITE1,
> .vmux = SAA7115_COMPOSITE0,
> .amux = EM28XX_AMUX_LINE_IN,
> }, {
> .type = EM28XX_VMUX_SVIDEO,
> .vmux = SAA7115_SVIDEO3,
> .amux = EM28XX_AMUX_LINE_IN,
> } },
> },
>
>
> Remy wants to change .amux for TV input from EM28XX_AMUX_LINE_IN to
> EM28XX_AMUX_VIDEO, which makes sense for the device he has.
> For my Cinergy 200, neither EM28XX_AMUX_VIDEO nor EM28XX_AMUX_LINE_IN
> works, because it misses an AC97 IC.
The only developer I know with em2800 hardware is Sascha Sommer. He may
help if you're noticing any issues with Cinergy 200. He is the one who
started writing this driver.
> Another question is, if we should remove the COMPOSITE input. At least
> Remys' and my device use a COMPOSITE to SVIDEO adapter cable.
If there are devices with it, the answer is no.
> The big question is now, if we can be sure that there are no other
> device variants, for which the current board definitions are right.
Very doubtful. Those are very old hardware. I bet that even Terratec
doesn't have any samples of it anymore.
> Especially because of the pictures with the additional connector on the
> side...
> But these pictures are all product pictures from Terratec, no one knows
> if they have ever been sold...
>
> So I'll leave it up to you to decide, which changes to make. :D
> But it's definitely time to close this old bug report. ;)
With regards to Cinergy 250, the better is to see if anyone at the ML
has a device using EM28XX_AMUX_LINE_IN for TV. If not, we can apply
the patch.
In that case, Remy should submit it, with his SOB, to the mailing list.
Regards,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)
2012-12-13 20:43 ` Mauro Carvalho Chehab
@ 2013-01-03 18:01 ` Frank Schäfer
2013-01-03 21:26 ` Remy Blank
0 siblings, 1 reply; 4+ messages in thread
From: Frank Schäfer @ 2013-01-03 18:01 UTC (permalink / raw)
To: remy.blank; +Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Sascha Sommer
Am 13.12.2012 21:43, schrieb Mauro Carvalho Chehab:
> Hi Frank,
>
> Em Thu, 13 Dec 2012 18:53:46 +0100
> Frank Schäfer <fschaefer.oss@googlemail.com> escreveu:
>
>> Hi Mauro,
>>
>> could you please take a look at kernel bug 14126
>> (https://bugzilla.kernel.org/show_bug.cgi?id=14126) ?
>> The bug reporter posted a patch 3 years ago (!), which seems to be valid.
>>
>> As mentioned in an earlier post, I've got a Cinergy 200 USB recently and
>> tried to figure out the difference between both devices:
>>
>> Common:
>> - handbook / product description from Terratec seems to be completely
>> identical (except that the number 200 is replaced with 250)
>> - both devices are looking identical
>> - Empia bridge
>> - saa7113
>> - tda9887
>> - remote control with external i2c IR IC
>> - physical connectors*: antenna, line-in and line-out (stereo jack), SVIDEO
>>
>> (*: some pictures show an additional connector on the side, but at least
>> Remys' and my device don't have it).
> Likely, some device variant. The driver should keep support for it, to avoid
> breaking support for those variants.
>> Cinergy 200 USB (my device):
>> - generic USB ID: eb1a:2800
>> - em2800
>> - no eeprom
>> - no AC97 IC
>> - LG TALN (tuner 66)
>> - audio over USB doesn't work
>> - audio line-in is shortcut with line-out
>>
>> Cinergy 250 USB (Remy's device):
>> - unique USB ID: 0ccd:0036
>> - em2820
>> - eeprom
>> - Empia 202 AC97
>> - LG TAPC (tuner 37)
>> - audio over USB works (from both, tuner and line-in)
>>
>>
>>
>> In the em28xx driver, we currently have the following board definitions:
>>
>> [EM2800_BOARD_TERRATEC_CINERGY_200] = {
>> .name = "Terratec Cinergy 200 USB",
>> .is_em2800 = 1,
>> .has_ir_i2c = 1,
>> .tuner_type = TUNER_LG_TALN,
>> .tda9887_conf = TDA9887_PRESENT,
>> .decoder = EM28XX_SAA711X,
>> .input = { {
>> .type = EM28XX_VMUX_TELEVISION,
>> .vmux = SAA7115_COMPOSITE2,
>> .amux = EM28XX_AMUX_VIDEO,
>> }, {
>> .type = EM28XX_VMUX_COMPOSITE1,
>> .vmux = SAA7115_COMPOSITE0,
>> .amux = EM28XX_AMUX_LINE_IN,
>> }, {
>> .type = EM28XX_VMUX_SVIDEO,
>> .vmux = SAA7115_SVIDEO3,
>> .amux = EM28XX_AMUX_LINE_IN,
>> } },
>> },
>>
>>
>> [EM2820_BOARD_TERRATEC_CINERGY_250] = {
>> .name = "Terratec Cinergy 250 USB",
>> .tuner_type = TUNER_LG_PAL_NEW_TAPC,
>> .has_ir_i2c = 1,
>> .tda9887_conf = TDA9887_PRESENT,
>> .decoder = EM28XX_SAA711X,
>> .input = { {
>> .type = EM28XX_VMUX_TELEVISION,
>> .vmux = SAA7115_COMPOSITE2,
>> .amux = EM28XX_AMUX_LINE_IN,
>> }, {
>> .type = EM28XX_VMUX_COMPOSITE1,
>> .vmux = SAA7115_COMPOSITE0,
>> .amux = EM28XX_AMUX_LINE_IN,
>> }, {
>> .type = EM28XX_VMUX_SVIDEO,
>> .vmux = SAA7115_SVIDEO3,
>> .amux = EM28XX_AMUX_LINE_IN,
>> } },
>> },
>>
>>
>> Remy wants to change .amux for TV input from EM28XX_AMUX_LINE_IN to
>> EM28XX_AMUX_VIDEO, which makes sense for the device he has.
>> For my Cinergy 200, neither EM28XX_AMUX_VIDEO nor EM28XX_AMUX_LINE_IN
>> works, because it misses an AC97 IC.
> The only developer I know with em2800 hardware is Sascha Sommer. He may
> help if you're noticing any issues with Cinergy 200. He is the one who
> started writing this driver.
>
>> Another question is, if we should remove the COMPOSITE input. At least
>> Remys' and my device use a COMPOSITE to SVIDEO adapter cable.
> If there are devices with it, the answer is no.
>
>> The big question is now, if we can be sure that there are no other
>> device variants, for which the current board definitions are right.
> Very doubtful. Those are very old hardware. I bet that even Terratec
> doesn't have any samples of it anymore.
>
>> Especially because of the pictures with the additional connector on the
>> side...
>> But these pictures are all product pictures from Terratec, no one knows
>> if they have ever been sold...
>>
>> So I'll leave it up to you to decide, which changes to make. :D
>> But it's definitely time to close this old bug report. ;)
> With regards to Cinergy 250, the better is to see if anyone at the ML
> has a device using EM28XX_AMUX_LINE_IN for TV. If not, we can apply
> the patch.
>
> In that case, Remy should submit it, with his SOB, to the mailing list.
>
> Regards,
> Mauro
Remy, your patch needs to be rebased against the linux-media tree.
Is it ok for you when I create a new patch including the composite input
fix and submit it ?
Of course I will give you the proper credits.
Regards,
Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)
2013-01-03 18:01 ` Frank Schäfer
@ 2013-01-03 21:26 ` Remy Blank
0 siblings, 0 replies; 4+ messages in thread
From: Remy Blank @ 2013-01-03 21:26 UTC (permalink / raw)
To: Frank Schäfer
Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Sascha Sommer
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
Frank Schäfer wrote:
> Remy, your patch needs to be rebased against the linux-media tree.
> Is it ok for you when I create a new patch including the composite input
> fix and submit it ?
Sure, please do. Thanks for taking the time to get this included.
-- Remy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-03 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-13 17:53 Bug 14126 (em28xx, Terratec Cinergy 200/250 USB) Frank Schäfer
2012-12-13 20:43 ` Mauro Carvalho Chehab
2013-01-03 18:01 ` Frank Schäfer
2013-01-03 21:26 ` Remy Blank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).