Re: [PATCH RFCv10 00/15] DVB QoS statistics API

[Antti Palosaari <crope@iki.fi>]

On 01/15/2013 04:30 AM, Mauro Carvalho Chehab wrote:

>      v6: Add DocBook documentation.
>      v7: Some fixes as suggested by Antti
>      v8: Documentation fix, compilation fix and name the stats struct,
>          for its reusage inside the core
>      v9: counters need 32 bits. So, change the return data types to
>          s32/u32 types
>      v10: Counters changed to 64 bits for monotonic increment
> 	 Don't create a separate get_stats callback. get_frontend
> 	 is already good enough for it.

Is there way to return BER as rate, or should it be calculated by the 
application (from total and error bit counts)?

You seems to change value to 64 bit already, which is enough. 32bit is 
absolutely too small, it will overflow in seconds (practically around 
10sec when there is radio channel of 32MHz and quite optimal conditions).

It is 64bit returned to userspace, is it? Does 64bit calculations causes 
any complexity of Kernel or app space?

Basically, that API is more complex that I would like to see, but I can 
live with it. I still fear making too complex API causes same problems 
as we has currently... lack of app support.

regards
Antti

-- 
http://palosaari.fi/