From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, ajaykumar.rs@samsung.com,
patches@linaro.org, Kamil Debski <k.debski@samsung.com>
Subject: Re: [PATCH] s5p-g2d: Add support for G2D H/W Rev.4.1
Date: Wed, 16 Jan 2013 11:13:30 +0100 [thread overview]
Message-ID: <50F67D4A.9010909@samsung.com> (raw)
In-Reply-To: <1357541069-7898-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
I have just one small comment...
On 01/07/2013 07:44 AM, Sachin Kamat wrote:
> +static void *g2d_get_drv_data(struct platform_device *pdev)
> +{
> + struct g2d_variant *driver_data = NULL;
> +
> + driver_data = (struct g2d_variant *)
> + platform_get_device_id(pdev)->driver_data;
> +
> + return driver_data;
> +}
How about adding this to g2d.h as:
static inline struct g2d_variant *g2d_get_drv_data(struct platform_device *pdev)
{
return (struct g2d_variant *)platform_get_device_id(pdev)->driver_data;
}
?
Otherwise the patch looks OK to me.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2013-01-16 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 6:44 [PATCH] s5p-g2d: Add support for G2D H/W Rev.4.1 Sachin Kamat
2013-01-16 10:13 ` Sylwester Nawrocki [this message]
2013-01-16 10:23 ` Sachin Kamat
2013-01-16 14:13 ` Kamil Debski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F67D4A.9010909@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=ajaykumar.rs@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox