From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, s.nawrocki@samsung.com, patches@linaro.org
Subject: Re: [PATCH 1/1] [media] s5k6aa: Use devm_regulator_bulk_get API
Date: Sun, 20 Jan 2013 19:47:38 +0100 [thread overview]
Message-ID: <50FC3BCA.9080301@gmail.com> (raw)
In-Reply-To: <1357627704-14269-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 01/08/2013 07:48 AM, Sachin Kamat wrote:
> devm_regulator_bulk_get is device managed and saves some cleanup
> and exit code.
Applied to my tree for 3.9, thanks.
I had some doubts initially, since this driver ideally needs to have
regulator_bulk_enable/disable function calls replaced with explicit
regulator_enable/regulator_disable calls, to ensure proper voltage
regulator enable/disable sequence (the bulk API doesn't guarantee
any specific sequence).
But this patch is just about regulator_get/regulator_put and it looks
fine.
--
Thanks,
Sylwester
prev parent reply other threads:[~2013-01-20 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 6:48 [PATCH 1/1] [media] s5k6aa: Use devm_regulator_bulk_get API Sachin Kamat
2013-01-20 18:47 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC3BCA.9080301@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=patches@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).