From: Antti Palosaari <crope@iki.fi>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] tda8290: Allow disabling I2C gate
Date: Mon, 21 Jan 2013 11:06:01 +0200 [thread overview]
Message-ID: <50FD04F9.5000401@iki.fi> (raw)
In-Reply-To: <201301210918.07199.linux@rainbow-software.org>
On 01/21/2013 10:18 AM, Ondrej Zary wrote:
> On Monday 21 January 2013, Antti Palosaari wrote:
>> On 01/20/2013 11:22 PM, Ondrej Zary wrote:
>>> Allow disabling I2C gate handling by external configuration.
>>> This is required by cards that have all devices on a single I2C bus,
>>> like AverMedia A706.
>>
>> My personal opinion is that I2C gate control should be disabled setting
>> callback to NULL (same for the other unwanted callbacks too). There is
>> checks for callback existence in DVB-core, it does not call callback if
>> it is NULL.
>
> This is TDA8290 internal I2C gate which is used by tda8290 internally and also
> by tda827x or tda18271.
That sounds like there is some logical problems in the driver then, not
split correctly?
What I think, scenario is tda8290 is analog decoder, tda18271 is silicon
tuner, which is connected (usually) to the tda8290 I2C bus. tda18271
calls tda8290 I2C-gate control when needed. Analog or digital demod
should not call its own I2C gate directly - and if it was done in some
weird reason then it should call own callback conditionally, checking
whether or not it is NULL.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-01-21 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 21:22 [PATCH 0/4] saa7134: Add AverMedia A706 AverTV Satellite Hybrid+FM Ondrej Zary
2013-01-20 21:22 ` [PATCH 1/4] tda8290: Allow disabling I2C gate Ondrej Zary
2013-01-21 8:06 ` Antti Palosaari
2013-01-21 8:18 ` Ondrej Zary
2013-01-21 9:06 ` Antti Palosaari [this message]
2013-01-21 18:28 ` Ondrej Zary
2013-01-23 17:31 ` Antti Palosaari
2013-01-20 21:22 ` [PATCH 2/4] tda8290: Allow custom std_map for tda18271 Ondrej Zary
2013-01-20 21:22 ` [PATCH 3/4] tuner-core: Change config from unsigned int to void * Ondrej Zary
2013-01-20 21:22 ` [PATCH 4/4] saa7134: Add AverMedia A706 AverTV Satellite Hybrid+FM Ondrej Zary
2013-01-27 21:45 ` [PATCH 4/4 v2] " Ondrej Zary
-- strict thread matches above, loose matches on Subject: below --
2013-02-01 20:21 [PATCH v2 0/4] " Ondrej Zary
2013-02-01 20:21 ` [PATCH 1/4] tda8290: Allow disabling I2C gate Ondrej Zary
2013-02-04 2:19 ` Michael Krufky
2013-02-04 18:56 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FD04F9.5000401@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).