From: Hans de Goede <hdegoede@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: partial revert of "uvcvideo: set error_idx properly"
Date: Fri, 25 Jan 2013 14:40:45 +0100 [thread overview]
Message-ID: <51028B5D.8080607@redhat.com> (raw)
In-Reply-To: <201301251140.13707.hverkuil@xs4all.nl>
Hi,
On 01/25/2013 11:40 AM, Hans Verkuil wrote:
<snip>
>> What I did notice is that pwc_vidioc_try_fmt returns EINVAL when
>> an unsupported pixelformat is requested. IIRC we agreed that the
>> correct behavior in this case is to instead just change the
>> pixelformat to a default format, so I'll write a patch fixing
>> this.
>
> There are issues with that idea in the case of TV capture cards, since
> some important apps (tvtime and mythtv to a lesser extent) assume -EINVAL
> in the case of unsupported pixelformats.
Oh, I thought we agreed on never returning EINVAL accept for on invalid
buffer types in Barcelona ?
Regards,
Hans
next prev parent reply other threads:[~2013-01-25 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKbGBLiOuyUUHd+eEm+z=THEu57b2LSDFtoN9frXASZ5BG7Huw@mail.gmail.com>
[not found] ` <CA+55aFxhXE8KbnjL7Nn3y0jd_wUFsdH6ZvsQ5EL+4cV3k3S4cg@mail.gmail.com>
[not found] ` <20121224213948.36514eca@redhat.com>
[not found] ` <20121225025648.5208189a@redhat.com>
2013-01-25 9:51 ` partial revert of "uvcvideo: set error_idx properly" Hans de Goede
2013-01-25 10:40 ` Hans Verkuil
2013-01-25 13:40 ` Hans de Goede [this message]
2013-01-25 13:42 ` Hans Verkuil
2013-01-27 13:57 ` Mauro Carvalho Chehab
2013-01-27 14:06 ` Mauro Carvalho Chehab
2013-01-28 10:04 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51028B5D.8080607@redhat.com \
--to=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox