From: Gregor Jasny <gjasny@googlemail.com>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: linux-media@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] v4l-utils: use openat when available
Date: Sat, 02 Feb 2013 15:08:20 +0100 [thread overview]
Message-ID: <510D1DD4.3060302@googlemail.com> (raw)
In-Reply-To: <1358872642-30843-1-git-send-email-riku.voipio@linaro.org>
Hello,
On 1/22/13 5:37 PM, Riku Voipio wrote:
> New architectures such as 64-Bit arm build kernels without legacy
> system calls - Such as the the no-at system calls. Thus, use
> SYS_openat whenever it is available.
> +#ifdef SYS_openat
> +#define SYS_OPEN(file, oflag, mode) \
> + syscall(SYS_openat, AT_FDCWD, (const char *)(file), (int)(oflag), (mode_t)(mode))
> +#else
> #define SYS_OPEN(file, oflag, mode) \
> syscall(SYS_open, (const char *)(file), (int)(oflag), (mode_t)(mode))
> +#endif
This would reduce compatibility to Linux >= 2.6.16 where openat was
introduced. How about testing for absence of SYS_open instead? Or fall
back to SYS_open if SYS_openat is not implemented?
Thanks,
Gregor
prev parent reply other threads:[~2013-02-02 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 16:37 [PATCH] v4l-utils: use openat when available Riku Voipio
2013-02-02 14:08 ` Gregor Jasny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510D1DD4.3060302@googlemail.com \
--to=gjasny@googlemail.com \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).