From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Devin Heitmueller <dheitmueller@kernellabs.com>,
Mr Goldcove <goldcove@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: Wrongly identified easycap em28xx
Date: Tue, 19 Feb 2013 20:45:21 +0100 [thread overview]
Message-ID: <5123D651.1090108@googlemail.com> (raw)
In-Reply-To: <20130219155303.25c5077a@redhat.com>
Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab:
> Em Tue, 19 Feb 2013 19:45:29 +0100
> Frank Schäfer <fschaefer.oss@googlemail.com> escreveu:
>
>>> I don't like the idea of merging those two entries. As far as I remember
>>> there are devices that works out of the box with
>>> EM2860_BOARD_SAA711X_REFERENCE_DESIGN. A change like that can break
>>> the driver for them.
>> As described above, there is a good chance to break devices with both
>> solutions.
>>
>> What's your suggestion ? ;-)
>>
> As I said, just leave it as-is (documenting at web)
That seems to be indeed the only 100%-regression-safe solution.
But also _no_ solution for this device.
A device which works only with a special module parameter passed on
driver loading isn't much better than an unsupported device.
It comes down to the following question:
Do we want to refuse fixing known/existing devices for the sake of
avoiding regression for unknown devices which even might not exist ? ;-)
I have no strong and final opinion yet. Still hoping someone knows how
the Empia driver handles these cases...
> or to use the AC97
> chip ID as a hint. This works fine for devices that don't come with
> Empiatech em202, but with something else, like the case of the Realtek
> chip found on this device. The reference design for sure uses em202.
How could the AC97 chip ID help us in this situation ?
As far as I understand, it doesn't matter which AC97 IC is used.
They are all compatible and at least our driver uses the same code for
all of them.
So even if you are are right and the Empia reference design uses an EMP202,
EM2860_BOARD_SAA711X_REFERENCE_DESIGN might work for devices with other
AC97-ICs, too.
We should also expect manufacturers to switch between them whenever they
want (e.g. because of price changes).
Regards,
Frank
next prev parent reply other threads:[~2013-02-19 19:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 20:53 Wrongly identified easycap em28xx Mr Goldcove
2013-02-18 21:25 ` Frank Schäfer
2013-02-18 22:36 ` Mr Goldcove
2013-02-19 16:02 ` Frank Schäfer
2013-02-19 16:51 ` Mr Goldcove
2013-02-19 16:47 ` Frank Schäfer
2013-02-19 18:30 ` Mauro Carvalho Chehab
2013-02-19 18:45 ` Frank Schäfer
2013-02-19 18:53 ` Mauro Carvalho Chehab
2013-02-19 19:45 ` Frank Schäfer [this message]
2013-02-19 20:03 ` Mauro Carvalho Chehab
2013-02-19 22:14 ` Frank Schäfer
2013-02-19 22:42 ` Mauro Carvalho Chehab
2013-02-20 18:15 ` Frank Schäfer
2013-02-20 5:09 ` Theodore Kilgore
2013-02-20 10:49 ` Andy Walls
2013-02-20 10:51 ` Mauro Carvalho Chehab
2013-02-20 18:23 ` Frank Schäfer
2013-02-20 18:20 ` Frank Schäfer
2013-02-20 19:12 ` Mauro Carvalho Chehab
2013-02-21 18:39 ` Frank Schäfer
2013-02-19 13:06 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123D651.1090108@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=dheitmueller@kernellabs.com \
--cc=goldcove@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).