Re: [PATCH v7 0/2] Add display-timing node parsing to exynos drm fimd

[Joonyoung Shim <jy0922.shim@samsung.com>]

Hi,

Please refer my comments about v6 patch.


On 02/21/2013 02:11 PM, Vikas Sajjan wrote:
> Add display-timing node parsing to drm fimd and depends on
> the display helper patchset at
> http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html
>
> It also adds pinctrl support for drm fimd.
>
> changes since v6:
> 	addressed comments from Inki Dae <inki.dae@samsung.com> to
> 	separated out the pinctrl functionality and made a separate patch.
>
> changes since v5:
> 	- addressed comments from Inki Dae <inki.dae@samsung.com>,
> 	to remove the allocation of 'fbmode' and replaced
> 	'-1'in "of_get_fb_videomode(dev->of_node, fbmode, -1)" with
> 	OF_USE_NATIVE_MODE.
>
> changes since v4:
> 	- addressed comments from Paul Menzel
> 	<paulepanter@users.sourceforge.net>, to modify the commit message
>
> changes since v3:
> 	- addressed comments from Sean Paul <seanpaul@chromium.org>, to modify
> 	the return values and print messages.
>
> changes since v2:
> 	- moved 'devm_pinctrl_get_select_default' function call under
> 		'if (pdev->dev.of_node)', this makes NON-DT code unchanged.
> 		(reported by: Rahul Sharma <r.sh.open@gmail.com>)
>
> changes since v1:
> 	- addressed comments from Sean Paul <seanpaul@chromium.org>
>
>
> Vikas Sajjan (2):
>    video: drm: exynos: Add display-timing node parsing using video
>      helper function
>    video: drm: exynos: Add pinctrl support to fimd
>
>   drivers/gpu/drm/exynos/exynos_drm_fimd.c |   36 ++++++++++++++++++++++++++----
>   1 file changed, 32 insertions(+), 4 deletions(-)
>