* [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
@ 2013-03-06 13:15 Arun Kumar K
2013-03-06 22:10 ` Sylwester Nawrocki
0 siblings, 1 reply; 6+ messages in thread
From: Arun Kumar K @ 2013-03-06 13:15 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, jtp.park, s.nawrocki, arun.kk
mfc-encoder is not working in the latest kernel giving the
erorr "Adding control (15) failed". Adding the missing step
parameter in this control to fix the issue.
Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 2356fd5..4f6b553 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -232,6 +232,7 @@ static struct mfc_control controls[] = {
.minimum = 0,
.maximum = 1,
.default_value = 0,
+ .step = 1,
.menu_skip_mask = 0,
},
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
2013-03-06 13:15 [PATCH] [media] s5p-mfc: Fix encoder control 15 issue Arun Kumar K
@ 2013-03-06 22:10 ` Sylwester Nawrocki
2013-03-07 2:20 ` Shaik Ameer Basha
2013-03-07 4:23 ` Arun Kumar K
0 siblings, 2 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2013-03-06 22:10 UTC (permalink / raw)
To: Arun Kumar K; +Cc: linux-media, k.debski, jtp.park, s.nawrocki
Hi Arun,
On 03/06/2013 02:15 PM, Arun Kumar K wrote:
> mfc-encoder is not working in the latest kernel giving the
> erorr "Adding control (15) failed". Adding the missing step
> parameter in this control to fix the issue.
Do you mean this problem was not observed in 3.8 kernel and something
has changed in the v4l2 core so it fails in 3.9-rc now ? Or is it
related to some change in the driver itself ?
> Signed-off-by: Arun Kumar K<arun.kk@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index 2356fd5..4f6b553 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -232,6 +232,7 @@ static struct mfc_control controls[] = {
> .minimum = 0,
> .maximum = 1,
> .default_value = 0,
> + .step = 1,
> .menu_skip_mask = 0,
> },
> {
Regards,
Sylwester
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
2013-03-06 22:10 ` Sylwester Nawrocki
@ 2013-03-07 2:20 ` Shaik Ameer Basha
2013-03-07 10:49 ` Sylwester Nawrocki
2013-03-07 4:23 ` Arun Kumar K
1 sibling, 1 reply; 6+ messages in thread
From: Shaik Ameer Basha @ 2013-03-07 2:20 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Arun Kumar K, linux-media, k.debski, jtp.park, s.nawrocki
Hi Sylwester,
On Thu, Mar 7, 2013 at 3:40 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> Hi Arun,
>
>
> On 03/06/2013 02:15 PM, Arun Kumar K wrote:
>>
>> mfc-encoder is not working in the latest kernel giving the
>> erorr "Adding control (15) failed". Adding the missing step
>> parameter in this control to fix the issue.
>
>
> Do you mean this problem was not observed in 3.8 kernel and something
> has changed in the v4l2 core so it fails in 3.9-rc now ? Or is it
> related to some change in the driver itself ?
v4l2_ctrl_new() uses check_range() for control range checking (which
is added newly).
This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control.
If 'step' value doesn't match to '1', it returns -ERANGE error.
Its a change in v4l2 core.
Regards,
Shaik Ameer Basha
>
>
>> Signed-off-by: Arun Kumar K<arun.kk@samsung.com>
>> ---
>> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> index 2356fd5..4f6b553 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> @@ -232,6 +232,7 @@ static struct mfc_control controls[] = {
>> .minimum = 0,
>> .maximum = 1,
>> .default_value = 0,
>> + .step = 1,
>> .menu_skip_mask = 0,
>> },
>> {
>
>
> Regards,
> Sylwester
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
2013-03-07 2:20 ` Shaik Ameer Basha
@ 2013-03-07 10:49 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2013-03-07 10:49 UTC (permalink / raw)
To: Shaik Ameer Basha
Cc: Arun Kumar K, linux-media, k.debski, jtp.park, s.nawrocki
On 03/07/2013 03:20 AM, Shaik Ameer Basha wrote:
> v4l2_ctrl_new() uses check_range() for control range checking (which
> is added newly).
> This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control.
> If 'step' value doesn't match to '1', it returns -ERANGE error.
>
> Its a change in v4l2 core.
Yes, I suspected the issue appeared after recent change
commit 88e85861b4f77ae29495ee05574c98dd0c6c3037
[media] v4l2-ctrl: Add helper function for the controls range update
Then it is related to to 3.9-rc1+ kernels only. I have verified it on
3.8 based kernel and there is no issue with drivers that do not
initialize step value for boolean type controls properly. It only
appears after the above commit is applied.
I've picked your fixup patches into v3.9-fixes branch and will try
to send them out this week, together with other patches from our side.
Regards,
Sylwester
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
2013-03-06 22:10 ` Sylwester Nawrocki
2013-03-07 2:20 ` Shaik Ameer Basha
@ 2013-03-07 4:23 ` Arun Kumar K
2013-03-07 10:51 ` Sylwester Nawrocki
1 sibling, 1 reply; 6+ messages in thread
From: Arun Kumar K @ 2013-03-07 4:23 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Arun Kumar K, LMML, Kamil Debski, jtp.park, Sylwester Nawrocki
Hi Sylwester,
> Do you mean this problem was not observed in 3.8 kernel and something
> has changed in the v4l2 core so it fails in 3.9-rc now ? Or is it
> related to some change in the driver itself ?
I saw this problem in 3.9rc1 and also in 3.8 stable.
But I havent seen this in media-tree v3.9 staging branch.
I didnt dig in much into what changed in v4l2 framework for this to happen now.
Regards
Arun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] s5p-mfc: Fix encoder control 15 issue
2013-03-07 4:23 ` Arun Kumar K
@ 2013-03-07 10:51 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2013-03-07 10:51 UTC (permalink / raw)
To: Arun Kumar K
Cc: Arun Kumar K, LMML, Kamil Debski, jtp.park, Sylwester Nawrocki
On 03/07/2013 05:23 AM, Arun Kumar K wrote:
>> Do you mean this problem was not observed in 3.8 kernel and something
>> has changed in the v4l2 core so it fails in 3.9-rc now ? Or is it
>> related to some change in the driver itself ?
>
> I saw this problem in 3.9rc1 and also in 3.8 stable.
> But I havent seen this in media-tree v3.9 staging branch.
> I didnt dig in much into what changed in v4l2 framework for this to happen now.
Thanks Arun. This is strange though, I haven't observe the problem
in 3.8. The issue seems to be related to
commit 88e85861b4f77ae29495ee05574c98dd0c6c3037
[media] v4l2-ctrl: Add helper function for the controls range update
which appeared in 3.9-rc1 only.
Regards,
Sylwester
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-07 10:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-06 13:15 [PATCH] [media] s5p-mfc: Fix encoder control 15 issue Arun Kumar K
2013-03-06 22:10 ` Sylwester Nawrocki
2013-03-07 2:20 ` Shaik Ameer Basha
2013-03-07 10:49 ` Sylwester Nawrocki
2013-03-07 4:23 ` Arun Kumar K
2013-03-07 10:51 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).