Re: [REVIEW PATCH 0/2] Add gfp_flags + silence vb2-dma-sg

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hello,

On 3/8/2013 10:21 AM, Hans Verkuil wrote:
> This patch series makes two modifications to videobuf2: the first adds the
> gfp_flags field allowing us to easily convert drivers that need GFP_DMA or
> __GFP_DMA32 to vb2. The stops the vb2-dma-sg module from logging every time
> buffers are allocating or released. Instead add a debug option.
>
> Marek, I understood from our earlier discussion that you are OK with doing
> it this way for now. If you can Ack this, then that would be great as that
> allows me to make a pull request for my solo driver changes.

I'm fine now. I hope I will manage to find some free time to finish dma-sg
allocator code cleanup, but this will definitely not happen till the next
merge window.

> One question: I'm OR-ing gfp_flags for dma-contig and dma-sg, but also in
> vmalloc. I'm not sure about the last one. I did it for consistency, but it
> is pretty useless, so if you think it is better to drop the vmalloc change,
> then that's no problem. Your call.

Let's leave it as is for better consistency.

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center