From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: [GIT PULL for v3.5] (v3) Control events support for uvcvideo
Date: Mon, 30 Apr 2012 12:17:03 +0200 [thread overview]
Message-ID: <5140337.GoVX3LbcVr@avalon> (raw)
In-Reply-To: <201204301149.54269.hverkuil@xs4all.nl>
Hi Hans,
On Monday 30 April 2012 11:49:54 Hans Verkuil wrote:
> On Monday 30 April 2012 11:43:10 Laurent Pinchart wrote:
> > Hi Mauro,
> >
> > A locking bug was present in the previous pull request. Please ignore it
> > and pull this one instead.
>
> I hate to say it, but while you did update v4l2_ctrl_add_event, you forgot
> to update v4l2_ctrl_del_event as well. That one still has the same locking
> issue...
If it wasn't noon already I'd blame it on not having woken up completely :-)
> Time for a v3 :-)
Here it is.
Mauro, could you please pull the following ? Sorry for the noise.
The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
[media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300)
are available in the git repository at:
git://linuxtv.org/pinchartl/uvcvideo.git uvcvideo-events
Hans de Goede (10):
media/radio: use v4l2_ctrl_subscribe_event where possible
v4l2-event: Add v4l2_subscribed_event_ops
v4l2-ctrls: Use v4l2_subscribed_event_ops
uvcvideo: Fix a "ignoring return value of ‘__clear_user’" warning
uvcvideo: Refactor uvc_ctrl_get and query
uvcvideo: Move __uvc_ctrl_get() up
uvcvideo: Add support for control events
uvcvideo: Properly report the inactive flag for inactive controls
uvcvideo: Send control change events for slave ctrls when the master changes
uvcvideo: Drop unused ctrl member from struct uvc_control_mapping
Documentation/video4linux/v4l2-framework.txt | 28 ++-
drivers/media/radio/radio-isa.c | 10 +-
drivers/media/radio/radio-keene.c | 14 +-
drivers/media/video/ivtv/ivtv-ioctl.c | 3 +-
drivers/media/video/omap3isp/ispccdc.c | 2 +-
drivers/media/video/omap3isp/ispstat.c | 2 +-
drivers/media/video/uvc/uvc_ctrl.c | 320 ++++++++++++++++++++++----
drivers/media/video/uvc/uvc_v4l2.c | 46 +++-
drivers/media/video/uvc/uvcvideo.h | 26 ++-
drivers/media/video/v4l2-ctrls.c | 41 +++-
drivers/media/video/v4l2-event.c | 71 +++---
drivers/usb/gadget/uvc_v4l2.c | 2 +-
include/media/v4l2-ctrls.h | 7 +-
include/media/v4l2-event.h | 24 ++-
14 files changed, 443 insertions(+), 153 deletions(-)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-04-30 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 17:59 [GIT PULL for v3.5] Control events support for uvcvideo Laurent Pinchart
2012-04-30 6:30 ` Hans Verkuil
2012-04-30 9:29 ` Laurent Pinchart
2012-04-30 9:43 ` [GIT PULL for v3.5] (v2) " Laurent Pinchart
2012-04-30 9:49 ` Hans Verkuil
2012-04-30 10:17 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140337.GoVX3LbcVr@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox