From: Sakari Ailus <sakari.ailus@iki.fi>
To: Wei Yongjun <weiyj.lk@gmail.com>,
mchehab@redhat.com, gregkh@linuxfoundation.org,
prabhakar.lad@ti.com, laurent.pinchart@ideasonboard.com,
hans.verkuil@cisco.com
Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH -next] [media] davinci: vpfe: fix return value check in vpfe_enable_clock()
Date: Sun, 17 Mar 2013 12:20:42 +0200 [thread overview]
Message-ID: <514598FA.7080400@iki.fi> (raw)
In-Reply-To: <CAPgLHd80DXpcUmY69Vcc72ALGh3LrSGPakm0iBeXNUqLY-+Nxg@mail.gmail.com>
Hi Wei,
Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Sakari Ailus <sakari.ailus@iki.fi>
--
Kind regards,
Sakari Ailus
sakari.ailus@iki.fi
prev parent reply other threads:[~2013-03-17 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 13:57 [PATCH -next] [media] davinci: vpfe: fix return value check in vpfe_enable_clock() Wei Yongjun
2013-03-12 4:42 ` Prabhakar Lad
2013-03-17 10:20 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514598FA.7080400@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=prabhakar.lad@ti.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).