* [PATCH] em28xx: fix typo in scale_to_size().
@ 2013-03-30 9:31 Hans Verkuil
2013-03-30 12:51 ` Frank Schäfer
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2013-03-30 9:31 UTC (permalink / raw)
To: linux-media; +Cc: Frank Schaefer, Hans de Goede
em28xx: fix typo in scale_to_size().
The second hscale should be vscale. This bug caused xawtv to fail because it
cannot find a workable image size.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
drivers/media/usb/em28xx/em28xx-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
index ef1959b..792ead1 100644
--- a/drivers/media/usb/em28xx/em28xx-video.c
+++ b/drivers/media/usb/em28xx/em28xx-video.c
@@ -996,7 +996,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
}
size_to_scale(dev, width, height, &hscale, &vscale);
- scale_to_size(dev, hscale, hscale, &width, &height);
+ scale_to_size(dev, hscale, vscale, &width, &height);
f->fmt.pix.width = width;
f->fmt.pix.height = height;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] em28xx: fix typo in scale_to_size().
2013-03-30 9:31 [PATCH] em28xx: fix typo in scale_to_size() Hans Verkuil
@ 2013-03-30 12:51 ` Frank Schäfer
0 siblings, 0 replies; 2+ messages in thread
From: Frank Schäfer @ 2013-03-30 12:51 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, Mauro Carvalho Chehab
Am 30.03.2013 10:31, schrieb Hans Verkuil:
> em28xx: fix typo in scale_to_size().
>
> The second hscale should be vscale. This bug caused xawtv to fail because it
> cannot find a workable image size.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/media/usb/em28xx/em28xx-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
> index ef1959b..792ead1 100644
> --- a/drivers/media/usb/em28xx/em28xx-video.c
> +++ b/drivers/media/usb/em28xx/em28xx-video.c
> @@ -996,7 +996,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
> }
>
> size_to_scale(dev, width, height, &hscale, &vscale);
> - scale_to_size(dev, hscale, hscale, &width, &height);
> + scale_to_size(dev, hscale, vscale, &width, &height);
>
> f->fmt.pix.width = width;
> f->fmt.pix.height = height;
Acked-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Thanks for catching this !
Regards,
Frank
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-30 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-30 9:31 [PATCH] em28xx: fix typo in scale_to_size() Hans Verkuil
2013-03-30 12:51 ` Frank Schäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).