From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: LMML <linux-media@vger.kernel.org>
Subject: Re: [PATCH 10/23] [media] exynos: remove unnecessary header inclusions
Date: Tue, 02 Apr 2013 15:17:25 +0200 [thread overview]
Message-ID: <515ADA65.4040100@samsung.com> (raw)
In-Reply-To: <515AD837.1060106@samsung.com>
On 04/02/2013 03:08 PM, Sylwester Nawrocki wrote:
> On 03/05/2013 06:42 PM, Arnd Bergmann wrote:
>> In multiplatform configurations, we cannot include headers
>> provided by only the exynos platform. Fortunately a number
>> of drivers that include those headers do not actually need
>> them, so we can just remove the inclusions.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/media/platform/exynos-gsc/gsc-regs.c | 1 -
>> drivers/media/platform/s5p-tv/sii9234_drv.c | 3 ---
>
> Cc: linux-media@vger.kernel.org
Uhh, now really added it to Cc.
> Thanks Arnd. I have applied this patch to my tree for 3.10.
>
>> 2 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/media/platform/exynos-gsc/gsc-regs.c b/drivers/media/platform/exynos-gsc/gsc-regs.c
>> index 6f5b5a4..e22d147 100644
>> --- a/drivers/media/platform/exynos-gsc/gsc-regs.c
>> +++ b/drivers/media/platform/exynos-gsc/gsc-regs.c
>> @@ -12,7 +12,6 @@
>>
>> #include <linux/io.h>
>> #include <linux/delay.h>
>> -#include <mach/map.h>
>>
>> #include "gsc-core.h"
>>
>> diff --git a/drivers/media/platform/s5p-tv/sii9234_drv.c b/drivers/media/platform/s5p-tv/sii9234_drv.c
>> index d90d228..39b77d2 100644
>> --- a/drivers/media/platform/s5p-tv/sii9234_drv.c
>> +++ b/drivers/media/platform/s5p-tv/sii9234_drv.c
>> @@ -23,9 +23,6 @@
>> #include <linux/regulator/machine.h>
>> #include <linux/slab.h>
>>
>> -#include <mach/gpio.h>
>> -#include <plat/gpio-cfg.h>
>> -
>> #include <media/sii9234.h>
>> #include <media/v4l2-subdev.h>
>
> --
>
> Regards,
> Sylwester
parent reply other threads:[~2013-04-02 13:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <515AD837.1060106@samsung.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515ADA65.4040100@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=arnd@arndb.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).