[PATCH -next] media:

[PATCH -next] media:

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

Fix randconfig error when USB is not enabled:

ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Antti Palosaari <crope@iki.fi>
---
 drivers/media/common/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20130408.orig/drivers/media/common/Kconfig
+++ linux-next-20130408/drivers/media/common/Kconfig
@@ -18,6 +18,7 @@ config VIDEO_TVEEPROM
 
 config CYPRESS_FIRMWARE
 	tristate "Cypress firmware helper routines"
+	depends on USB
 
 source "drivers/media/common/b2c2/Kconfig"
 source "drivers/media/common/saa7146/Kconfig"

Re: [PATCH -next] media:

[Antti Palosaari]

On 04/08/2013 08:47 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix randconfig error when USB is not enabled:
>
> ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Antti Palosaari <crope@iki.fi>

Reviewed-by: Antti Palosaari <crope@iki.fi>


> ---
>   drivers/media/common/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20130408.orig/drivers/media/common/Kconfig
> +++ linux-next-20130408/drivers/media/common/Kconfig
> @@ -18,6 +18,7 @@ config VIDEO_TVEEPROM
>
>   config CYPRESS_FIRMWARE
>   	tristate "Cypress firmware helper routines"
> +	depends on USB
>
>   source "drivers/media/common/b2c2/Kconfig"
>   source "drivers/media/common/saa7146/Kconfig"
>


-- 
http://palosaari.fi/

Re: [PATCH -next] media:

[David Rientjes]

On Tue, 9 Apr 2013, Antti Palosaari wrote:

> On 04/08/2013 08:47 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix randconfig error when USB is not enabled:
> > 
> > ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko]
> > undefined!
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Antti Palosaari <crope@iki.fi>
> 
> Reviewed-by: Antti Palosaari <crope@iki.fi>
> 
> 
> > ---
> >   drivers/media/common/Kconfig |    1 +
> >   1 file changed, 1 insertion(+)
> > 
> > --- linux-next-20130408.orig/drivers/media/common/Kconfig
> > +++ linux-next-20130408/drivers/media/common/Kconfig
> > @@ -18,6 +18,7 @@ config VIDEO_TVEEPROM
> > 
> >   config CYPRESS_FIRMWARE
> >   	tristate "Cypress firmware helper routines"
> > +	depends on USB
> > 
> >   source "drivers/media/common/b2c2/Kconfig"
> >   source "drivers/media/common/saa7146/Kconfig"
> > 

Mauro, this problem persists in linux-next seven days later, any chance we 
can get this fix from Randy merged?

Re: [PATCH -next] media:

[Mauro Carvalho Chehab]

Em Mon, 15 Apr 2013 20:10:49 -0700 (PDT)
David Rientjes <rientjes@google.com> escreveu:

> On Tue, 9 Apr 2013, Antti Palosaari wrote:
> 
> > On 04/08/2013 08:47 PM, Randy Dunlap wrote:
> > > From: Randy Dunlap <rdunlap@infradead.org>
> > > 
> > > Fix randconfig error when USB is not enabled:
> > > 
> > > ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko]
> > > undefined!
> > > 
> > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > Cc: Antti Palosaari <crope@iki.fi>
> > 
> > Reviewed-by: Antti Palosaari <crope@iki.fi>
> > 
> > 
> > > ---
> > >   drivers/media/common/Kconfig |    1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > --- linux-next-20130408.orig/drivers/media/common/Kconfig
> > > +++ linux-next-20130408/drivers/media/common/Kconfig
> > > @@ -18,6 +18,7 @@ config VIDEO_TVEEPROM
> > > 
> > >   config CYPRESS_FIRMWARE
> > >   	tristate "Cypress firmware helper routines"
> > > +	depends on USB
> > > 
> > >   source "drivers/media/common/b2c2/Kconfig"
> > >   source "drivers/media/common/saa7146/Kconfig"
> > > 
> 
> Mauro, this problem persists in linux-next seven days later, any chance we 
> can get this fix from Randy merged?

AFAIKT, this got merged at -next already:

commit 7c15b715ef301a7f8bb2dc8de335497ffde568a6
Author:     Randy Dunlap <rdunlap@infradead.org>
AuthorDate: Mon Apr 8 13:47:03 2013 -0300
Commit:     Mauro Carvalho Chehab <mchehab@redhat.com>
CommitDate: Sun Apr 14 20:04:08 2013 -0300

    [media] media: Fix randconfig error
    
    Fix randconfig error when USB is not enabled:
    ERROR: "usb_control_msg" [drivers/media/common/cypress_firmware.ko] undefined!
    
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Reviewed-by: Antti Palosaari <crope@iki.fi>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Regards,
Mauro

[PATCH -next] staging/media: fix go7007 dependencies and build

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

VIDEO_GO7007 uses usb interfaces so it should depend on USB.
It also selects CYPRESS_FIRMWARE, which depends on USB.

Fixes build errors and a kconfig warning:

go7007-loader.c:(.text+0xcc7d0): undefined reference to `usb_get_dev'
go7007-loader.c:(.init.text+0x49f0): undefined reference to `usb_register_driver'
go7007-loader.c:(.exit.text+0x17ce): undefined reference to `usb_deregister'

warning: (DVB_USB_AZ6007 && VIDEO_GO7007) selects CYPRESS_FIRMWARE which has unmet direct dependencies (MEDIA_SUPPORT && USB)

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/staging/media/go7007/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20130416.orig/drivers/staging/media/go7007/Kconfig
+++ linux-next-20130416/drivers/staging/media/go7007/Kconfig
@@ -1,7 +1,7 @@
 config VIDEO_GO7007
 	tristate "WIS GO7007 MPEG encoder support"
 	depends on VIDEO_DEV && I2C
-	depends on SND
+	depends on SND && USB
 	select VIDEOBUF2_VMALLOC
 	select VIDEO_TUNER
 	select CYPRESS_FIRMWARE