From: Antti Palosaari <crope@iki.fi>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach()
Date: Thu, 25 Apr 2013 18:57:31 +0300 [thread overview]
Message-ID: <5179526B.9030307@iki.fi> (raw)
In-Reply-To: <1366803406-17738-1-git-send-email-geert@linux-m68k.org>
On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote:
> drivers/media/usb/dvb-usb-v2/anysee.c: In function ‘anysee_frontend_attach’:
> drivers/media/usb/dvb-usb-v2/anysee.c:641: warning: ‘ret’ may be used uninitialized in this function
>
> And gcc is right (see the ANYSEE_HW_507T case), so initialize ret to zero
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
> index a20d691..3a1f976 100644
> --- a/drivers/media/usb/dvb-usb-v2/anysee.c
> +++ b/drivers/media/usb/dvb-usb-v2/anysee.c
> @@ -638,7 +638,7 @@ static int anysee_frontend_attach(struct dvb_usb_adapter *adap)
> {
> struct anysee_state *state = adap_to_priv(adap);
> struct dvb_usb_device *d = adap_to_d(adap);
> - int ret;
> + int ret = 0;
> u8 tmp;
> struct i2c_msg msg[2] = {
> {
>
--
http://palosaari.fi/
prev parent reply other threads:[~2013-04-25 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 11:36 [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach() Geert Uytterhoeven
2013-04-24 11:36 ` [PATCH 2/2] [media] anysee: Grammar s/report the/report to/ Geert Uytterhoeven
2013-04-25 15:58 ` Antti Palosaari
2013-04-25 15:57 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5179526B.9030307@iki.fi \
--to=crope@iki.fi \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).