From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
"uclinux-dist-devel@blackfin.uclinux.org"
<uclinux-dist-devel@blackfin.uclinux.org>
Subject: Re: [PATCH RFC] [media] blackfin: add video display driver
Date: Thu, 25 Apr 2013 22:37:18 +0200 [thread overview]
Message-ID: <517993FE.8050608@gmail.com> (raw)
In-Reply-To: <CAHG8p1B2meHySHWnQ6JAhDA+2Cgfyc=JHcAG8eY9GhcpN7B5iA@mail.gmail.com>
Hi Scott,
On 04/24/2013 11:26 AM, Scott Jiang wrote:
>>
>>> + struct v4l2_device v4l2_dev;
>>> + /* v4l2 control handler */
>>> + struct v4l2_ctrl_handler ctrl_handler;
>>
>>
>> This handler seems to be unused, I couldn't find any code adding controls
>> to it. Any initialization of this handler is a dead code now. You probably
>> want to move that bits to a patch actually adding any controls.
>>
>
> This host driver doesn't support any control but without it subdev
> controls can't be accessed.
> v4l2_ctrl_add_handler should just return 0 if v4l2_dev->ctrl_handler is NULL.
You're right, I missed the point that a video device could expose just
controls
inherited from subdevs. And for that its control handler need to be
initialized.
So I didn't help you too much with that comment, please just ignore it.
Regards,
Sylwester
next prev parent reply other threads:[~2013-04-25 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 23:52 [PATCH 1/2] [media] blackfin: add display support in ppi driver Scott Jiang
2013-04-12 11:32 ` Hans Verkuil
2013-04-15 2:59 ` Scott Jiang
2013-04-12 23:52 ` [PATCH RFC] [media] blackfin: add video display driver Scott Jiang
2013-04-12 22:28 ` Sylwester Nawrocki
2013-04-17 6:57 ` Scott Jiang
2013-04-18 21:22 ` Sylwester Nawrocki
2013-04-24 9:26 ` Scott Jiang
2013-04-25 20:37 ` Sylwester Nawrocki [this message]
2013-04-15 15:03 ` Hans Verkuil
2013-04-16 10:41 ` Scott Jiang
2013-04-12 23:52 ` [PATCH 2/2] [media] bfin_capture: add query_dv_timings/enum_dv_timings support Scott Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517993FE.8050608@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).