* [PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index
@ 2013-04-30 4:42 Axel Lin
2013-04-30 8:46 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-04-30 4:42 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Kyungmin Park, Andrzej Hajda, linux-media
Current code uses fie->index as array subscript, thus the valid value range
is 0 ... ARRAY_SIZE(s5c73m3_intervals) - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index b353c50..cd365bb 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
@@ -956,7 +956,7 @@ static int s5c73m3_oif_enum_frame_interval(struct v4l2_subdev *sd,
if (fie->pad != OIF_SOURCE_PAD)
return -EINVAL;
- if (fie->index > ARRAY_SIZE(s5c73m3_intervals))
+ if (fie->index >= ARRAY_SIZE(s5c73m3_intervals))
return -EINVAL;
mutex_lock(&state->lock);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index
2013-04-30 4:42 [PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index Axel Lin
@ 2013-04-30 8:46 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2013-04-30 8:46 UTC (permalink / raw)
To: Axel Lin; +Cc: Mauro Carvalho Chehab, Kyungmin Park, linux-media
Hi Axel,
Thanks for the fix.
On 30.04.2013 06:42, Axel Lin wrote:
> Current code uses fie->index as array subscript, thus the valid value range
> is 0 ... ARRAY_SIZE(s5c73m3_intervals) - 1.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> index b353c50..cd365bb 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> @@ -956,7 +956,7 @@ static int s5c73m3_oif_enum_frame_interval(struct v4l2_subdev *sd,
>
> if (fie->pad != OIF_SOURCE_PAD)
> return -EINVAL;
> - if (fie->index > ARRAY_SIZE(s5c73m3_intervals))
> + if (fie->index >= ARRAY_SIZE(s5c73m3_intervals))
> return -EINVAL;
>
> mutex_lock(&state->lock);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-30 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-30 4:42 [PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index Axel Lin
2013-04-30 8:46 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox