* [PATCH] mt9p031: Use gpio_is_valid()
@ 2013-05-02 11:04 Laurent Pinchart
2013-05-02 20:15 ` Sylwester Nawrocki
2013-05-03 6:12 ` Prabhakar Lad
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-05-02 11:04 UTC (permalink / raw)
To: linux-media; +Cc: Prabhakar Lad
Replace the manual validity checks for the reset GPIO with the
gpio_is_valid() function.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/mt9p031.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index 8de84c0..bf49899 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -272,7 +272,7 @@ static inline int mt9p031_pll_disable(struct mt9p031 *mt9p031)
static int mt9p031_power_on(struct mt9p031 *mt9p031)
{
/* Ensure RESET_BAR is low */
- if (mt9p031->reset != -1) {
+ if (gpio_is_valid(mt9p031->reset)) {
gpio_set_value(mt9p031->reset, 0);
usleep_range(1000, 2000);
}
@@ -287,7 +287,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031)
clk_prepare_enable(mt9p031->clk);
/* Now RESET_BAR must be high */
- if (mt9p031->reset != -1) {
+ if (gpio_is_valid(mt9p031->reset)) {
gpio_set_value(mt9p031->reset, 1);
usleep_range(1000, 2000);
}
@@ -297,7 +297,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031)
static void mt9p031_power_off(struct mt9p031 *mt9p031)
{
- if (mt9p031->reset != -1) {
+ if (gpio_is_valid(mt9p031->reset)) {
gpio_set_value(mt9p031->reset, 0);
usleep_range(1000, 2000);
}
@@ -1031,7 +1031,7 @@ static int mt9p031_probe(struct i2c_client *client,
mt9p031->format.field = V4L2_FIELD_NONE;
mt9p031->format.colorspace = V4L2_COLORSPACE_SRGB;
- if (pdata->reset != -1) {
+ if (gpio_is_valid(pdata->reset)) {
ret = devm_gpio_request_one(&client->dev, pdata->reset,
GPIOF_OUT_INIT_LOW, "mt9p031_rst");
if (ret < 0)
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt9p031: Use gpio_is_valid()
2013-05-02 11:04 [PATCH] mt9p031: Use gpio_is_valid() Laurent Pinchart
@ 2013-05-02 20:15 ` Sylwester Nawrocki
2013-05-03 6:12 ` Prabhakar Lad
1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2013-05-02 20:15 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Prabhakar Lad
On 05/02/2013 01:04 PM, Laurent Pinchart wrote:
> Replace the manual validity checks for the reset GPIO with the
> gpio_is_valid() function.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/media/i2c/mt9p031.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index 8de84c0..bf49899 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -272,7 +272,7 @@ static inline int mt9p031_pll_disable(struct mt9p031 *mt9p031)
> static int mt9p031_power_on(struct mt9p031 *mt9p031)
> {
> /* Ensure RESET_BAR is low */
> - if (mt9p031->reset != -1) {
> + if (gpio_is_valid(mt9p031->reset)) {
> gpio_set_value(mt9p031->reset, 0);
> usleep_range(1000, 2000);
> }
> @@ -287,7 +287,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031)
> clk_prepare_enable(mt9p031->clk);
>
> /* Now RESET_BAR must be high */
> - if (mt9p031->reset != -1) {
> + if (gpio_is_valid(mt9p031->reset)) {
> gpio_set_value(mt9p031->reset, 1);
> usleep_range(1000, 2000);
> }
> @@ -297,7 +297,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031)
>
> static void mt9p031_power_off(struct mt9p031 *mt9p031)
> {
> - if (mt9p031->reset != -1) {
> + if (gpio_is_valid(mt9p031->reset)) {
> gpio_set_value(mt9p031->reset, 0);
> usleep_range(1000, 2000);
> }
> @@ -1031,7 +1031,7 @@ static int mt9p031_probe(struct i2c_client *client,
> mt9p031->format.field = V4L2_FIELD_NONE;
> mt9p031->format.colorspace = V4L2_COLORSPACE_SRGB;
>
> - if (pdata->reset != -1) {
> + if (gpio_is_valid(pdata->reset)) {
> ret = devm_gpio_request_one(&client->dev, pdata->reset,
> GPIOF_OUT_INIT_LOW, "mt9p031_rst");
> if (ret< 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt9p031: Use gpio_is_valid()
2013-05-02 11:04 [PATCH] mt9p031: Use gpio_is_valid() Laurent Pinchart
2013-05-02 20:15 ` Sylwester Nawrocki
@ 2013-05-03 6:12 ` Prabhakar Lad
1 sibling, 0 replies; 3+ messages in thread
From: Prabhakar Lad @ 2013-05-03 6:12 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media
Hi Laurent,
Thanks for the patch.
On Thu, May 2, 2013 at 4:34 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Replace the manual validity checks for the reset GPIO with the
> gpio_is_valid() function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-03 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 11:04 [PATCH] mt9p031: Use gpio_is_valid() Laurent Pinchart
2013-05-02 20:15 ` Sylwester Nawrocki
2013-05-03 6:12 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox