From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ee0-f52.google.com ([74.125.83.52]:58696 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761535Ab3EBUPh (ORCPT ); Thu, 2 May 2013 16:15:37 -0400 Received: by mail-ee0-f52.google.com with SMTP id d41so440979eek.25 for ; Thu, 02 May 2013 13:15:36 -0700 (PDT) Message-ID: <5182C965.1040804@gmail.com> Date: Thu, 02 May 2013 22:15:33 +0200 From: Sylwester Nawrocki MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org, Prabhakar Lad Subject: Re: [PATCH] mt9p031: Use gpio_is_valid() References: <1367492652-28704-1-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1367492652-28704-1-git-send-email-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05/02/2013 01:04 PM, Laurent Pinchart wrote: > Replace the manual validity checks for the reset GPIO with the > gpio_is_valid() function. > > Signed-off-by: Laurent Pinchart Reviewed-by: Sylwester Nawrocki > --- > drivers/media/i2c/mt9p031.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c > index 8de84c0..bf49899 100644 > --- a/drivers/media/i2c/mt9p031.c > +++ b/drivers/media/i2c/mt9p031.c > @@ -272,7 +272,7 @@ static inline int mt9p031_pll_disable(struct mt9p031 *mt9p031) > static int mt9p031_power_on(struct mt9p031 *mt9p031) > { > /* Ensure RESET_BAR is low */ > - if (mt9p031->reset != -1) { > + if (gpio_is_valid(mt9p031->reset)) { > gpio_set_value(mt9p031->reset, 0); > usleep_range(1000, 2000); > } > @@ -287,7 +287,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031) > clk_prepare_enable(mt9p031->clk); > > /* Now RESET_BAR must be high */ > - if (mt9p031->reset != -1) { > + if (gpio_is_valid(mt9p031->reset)) { > gpio_set_value(mt9p031->reset, 1); > usleep_range(1000, 2000); > } > @@ -297,7 +297,7 @@ static int mt9p031_power_on(struct mt9p031 *mt9p031) > > static void mt9p031_power_off(struct mt9p031 *mt9p031) > { > - if (mt9p031->reset != -1) { > + if (gpio_is_valid(mt9p031->reset)) { > gpio_set_value(mt9p031->reset, 0); > usleep_range(1000, 2000); > } > @@ -1031,7 +1031,7 @@ static int mt9p031_probe(struct i2c_client *client, > mt9p031->format.field = V4L2_FIELD_NONE; > mt9p031->format.colorspace = V4L2_COLORSPACE_SRGB; > > - if (pdata->reset != -1) { > + if (gpio_is_valid(pdata->reset)) { > ret = devm_gpio_request_one(&client->dev, pdata->reset, > GPIOF_OUT_INIT_LOW, "mt9p031_rst"); > if (ret< 0)