From: Andrzej Hajda <a.hajda@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kamil Debski <k.debski@samsung.com>,
linux-media@vger.kernel.org, Jeongtae Park <jtp.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/3] s5p-mfc: separate encoder parameters for h264 and mpeg4
Date: Tue, 28 May 2013 11:11:38 +0200 [thread overview]
Message-ID: <51A474CA.4040303@samsung.com> (raw)
In-Reply-To: <CAK9yfHytCAvghurn8djWOKtf7MYsZbfjgu9yuBbmPPrC8tu4yA@mail.gmail.com>
On 05/28/2013 10:31 AM, Sachin Kamat wrote:
> Hi Andrzej,
>
> On 28 May 2013 12:56, Andrzej Hajda <a.hajda@samsung.com> wrote:
>> This patch fixes a bug which caused overwriting h264 codec
>> parameters by mpeg4 parameters during V4L2 control setting.
> Just curious, what was the use case that triggered this issue?
>
For example it was not possible to set h264 profile and level -
they were overwritten by "struct s5p_mfc_mpeg4_enc_params" fields.
In general all 'union' fields of s5p_mfc_h264_enc_params were
overwritten by
s5p_mfc_mpeg4_enc_params and vice versa, the control which was set later
was 'the winner'.
Furthermore during stream start v4l2_ctrl_handler_setup was called so
all controls
were refreshed, so the final winners order was determined by controls
definition order.
Regards
Andrzej
next prev parent reply other threads:[~2013-05-28 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 7:26 [PATCH 0/3] s5p-mfc encoder fixes Andrzej Hajda
2013-05-28 7:26 ` [PATCH 1/3] s5p-mfc: separate encoder parameters for h264 and mpeg4 Andrzej Hajda
2013-05-28 8:31 ` Sachin Kamat
2013-05-28 9:11 ` Andrzej Hajda [this message]
2013-05-28 7:26 ` [PATCH 2/3] s5p-mfc: v4l2 controls setup routine moved to initialization code Andrzej Hajda
2013-05-28 7:26 ` [PATCH 3/3] s5p-mfc: added missing end-of-lines in debug messages Andrzej Hajda
2013-05-28 8:42 ` Sachin Kamat
2013-05-28 9:38 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A474CA.4040303@samsung.com \
--to=a.hajda@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox