From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Pawel Osciak <pawel@osciak.com>, John Sheu <sheu@google.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Kamil Debski <k.debski@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [RFC PATCH v3] [media] mem2mem: add support for hardware buffered queue
Date: Fri, 31 May 2013 10:52:21 +0200 [thread overview]
Message-ID: <51A864C5.4090703@samsung.com> (raw)
In-Reply-To: <1369989199-20952-1-git-send-email-p.zabel@pengutronix.de>
Hi Philipp,
On 05/31/2013 10:33 AM, Philipp Zabel wrote:
> +void v4l2_m2m_queue_set_buffered(struct vb2_queue *vq, bool buffered)
How about making it a 'static inline' function in include/media/v4l2-mem2mem.h
instead ?
> +{
> + struct v4l2_m2m_queue_ctx *q_ctx = container_of(vq, struct v4l2_m2m_queue_ctx, q);
> +
> + q_ctx->buffered = buffered;
> +}
> +EXPORT_SYMBOL_GPL(v4l2_m2m_queue_set_buffered);
Also, I was wondering how do you handle now in the coda driver a situation
when, e.g. during normal stream decoding more than one buffer is produced
by the decoder from one compressed data buffer on its input side ?
Regards,
Sylwester
--
Sylwester Nawrocki
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-05-31 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 8:33 [RFC PATCH v3] [media] mem2mem: add support for hardware buffered queue Philipp Zabel
2013-05-31 8:52 ` Sylwester Nawrocki [this message]
2013-05-31 9:29 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A864C5.4090703@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel@osciak.com \
--cc=sheu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox