[PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

[PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

[Sylwester Nawrocki]

Update the documentation with the driver's path changed in
commit 56fa1a6a6a7da91e7ece8b01b0ae8adb2926e434
[media] s5p-fimc: Change the driver directory to exynos4-is

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 Documentation/video4linux/fimc.txt |   21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/Documentation/video4linux/fimc.txt b/Documentation/video4linux/fimc.txt
index 25f4d34..e51f1b5 100644
--- a/Documentation/video4linux/fimc.txt
+++ b/Documentation/video4linux/fimc.txt
@@ -1,6 +1,6 @@
 Samsung S5P/EXYNOS4 FIMC driver
 
-Copyright (C) 2012 Samsung Electronics Co., Ltd.
+Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
 ---------------------------------------------------------------------------
 
 The FIMC (Fully Interactive Mobile Camera) device available in Samsung
@@ -10,7 +10,7 @@ data from LCD controller (FIMD) through the SoC internal writeback data
 path.  There are multiple FIMC instances in the SoCs (up to 4), having
 slightly different capabilities, like pixel alignment constraints, rotator
 availability, LCD writeback support, etc. The driver is located at
-drivers/media/platform/s5p-fimc directory.
+drivers/media/platform/exynos4-is directory.
 
 1. Supported SoCs
 =================
@@ -36,21 +36,21 @@ Not currently supported:
 =====================
 
 - media device driver
-  drivers/media/platform/s5p-fimc/fimc-mdevice.[ch]
+  drivers/media/platform/exynos4-is/media-dev.[ch]
 
  - camera capture video device driver
-  drivers/media/platform/s5p-fimc/fimc-capture.c
+  drivers/media/platform/exynos4-is/fimc-capture.c
 
  - MIPI-CSI2 receiver subdev
-  drivers/media/platform/s5p-fimc/mipi-csis.[ch]
+  drivers/media/platform/exynos4-is/mipi-csis.[ch]
 
  - video post-processor (mem-to-mem)
-  drivers/media/platform/s5p-fimc/fimc-core.c
+  drivers/media/platform/exynos4-is/fimc-core.c
 
  - common files
-  drivers/media/platform/s5p-fimc/fimc-core.h
-  drivers/media/platform/s5p-fimc/fimc-reg.h
-  drivers/media/platform/s5p-fimc/regs-fimc.h
+  drivers/media/platform/exynos4-is/fimc-core.h
+  drivers/media/platform/exynos4-is/fimc-reg.h
+  drivers/media/platform/exynos4-is/regs-fimc.h
 
 4. User space interfaces
 ========================
@@ -143,7 +143,8 @@ or retrieve the information from /dev/media? with help of the media-ctl tool:
 6. Platform support
 ===================
 
-The machine code (plat-s5p and arch/arm/mach-*) must select following options
+The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select
+following options:
 
 CONFIG_S5P_DEV_FIMC0       mandatory
 CONFIG_S5P_DEV_FIMC1  \
-- 
1.7.9.5

Re: [PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

[Sachin Kamat]

Hi Sylwester,

>
> -The machine code (plat-s5p and arch/arm/mach-*) must select following options
> +The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select
> +following options:

After the recent platform code cleanup the below entries are not found
in arch/arm/mach-* (checked in linux-next).

>
>  CONFIG_S5P_DEV_FIMC0       mandatory
>  CONFIG_S5P_DEV_FIMC1  \

-- 
With warm regards,
Sachin

Re: [PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

[Sylwester Nawrocki]

Hi Sachin,

On 06/18/2013 05:45 AM, Sachin Kamat wrote:
> Hi Sylwester,
>
>> -The machine code (plat-s5p and arch/arm/mach-*) must select following options
>> +The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select
>> +following options:
>
> After the recent platform code cleanup the below entries are not found
> in arch/arm/mach-* (checked in linux-next).
>
>>   CONFIG_S5P_DEV_FIMC0       mandatory
>>   CONFIG_S5P_DEV_FIMC1  \

AFAICS some are still there:

$ git grep S5P_DEV_FIMC0
Documentation/video4linux/fimc.txt:CONFIG_S5P_DEV_FIMC0       mandatory
arch/arm/mach-s5pc100/Kconfig:  select S5P_DEV_FIMC0
arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
arch/arm/plat-samsung/Kconfig:config S5P_DEV_FIMC0
arch/arm/plat-samsung/devs.c:#ifdef CONFIG_S5P_DEV_FIMC0
arch/arm/plat-samsung/devs.c:#endif /* CONFIG_S5P_DEV_FIMC0 */
arch/arm/plat-samsung/include/plat/fimc-core.h:#ifdef CONFIG_S5P_DEV_FIMC0

Those symbols have been removed only for Exynos. The above can be dropped
once we convert S5PV210 and S5PC100 (or drop support for this platform)
to Device Tree.

Anyway, I'm planning to update this FIMC documentation in a separate patch
to account for all the recent changes, especially addition of the FIMC-IS
support. But that will likely be only for 3.12.

Regards,
Sylwester

Re: [PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

[Sachin Kamat]

Hi Sylwester,

On 19 June 2013 03:27, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote:
> Hi Sachin,
>
>
> On 06/18/2013 05:45 AM, Sachin Kamat wrote:
>>
>> Hi Sylwester,
>>
>>> -The machine code (plat-s5p and arch/arm/mach-*) must select following
>>> options
>>> +The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select
>>> +following options:
>>
>>
>> After the recent platform code cleanup the below entries are not found
>> in arch/arm/mach-* (checked in linux-next).
>>
>>>   CONFIG_S5P_DEV_FIMC0       mandatory
>>>   CONFIG_S5P_DEV_FIMC1  \
>
>
> AFAICS some are still there:
>
> $ git grep S5P_DEV_FIMC0
> Documentation/video4linux/fimc.txt:CONFIG_S5P_DEV_FIMC0       mandatory
> arch/arm/mach-s5pc100/Kconfig:  select S5P_DEV_FIMC0
> arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
> arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
> arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
> arch/arm/mach-s5pv210/Kconfig:  select S5P_DEV_FIMC0
> arch/arm/plat-samsung/Kconfig:config S5P_DEV_FIMC0
> arch/arm/plat-samsung/devs.c:#ifdef CONFIG_S5P_DEV_FIMC0
> arch/arm/plat-samsung/devs.c:#endif /* CONFIG_S5P_DEV_FIMC0 */
> arch/arm/plat-samsung/include/plat/fimc-core.h:#ifdef CONFIG_S5P_DEV_FIMC0
>
> Those symbols have been removed only for Exynos. The above can be dropped
> once we convert S5PV210 and S5PC100 (or drop support for this platform)
> to Device Tree.

Yes you are right. Probably I mis-grepped it.

-- 
With warm regards,
Sachin