From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: balbi@ti.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kishon@ti.com,
linux-media@vger.kernel.org, kyungmin.park@samsung.com,
t.figa@samsung.com, devicetree-discuss@lists.ozlabs.org,
kgene.kim@samsung.com, dh09.lee@samsung.com, jg1.han@samsung.com,
inki.dae@samsung.com, plagnioj@jcrosoft.com,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs
Date: Wed, 26 Jun 2013 17:00:34 +0200 [thread overview]
Message-ID: <51CB0212.3050103@samsung.com> (raw)
In-Reply-To: <20130625150649.GA21334@arwen.pp.htv.fi>
Hi,
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
>> +static struct platform_driver exynos_video_phy_driver = {
>> > + .probe = exynos_video_phy_probe,
>
> you *must* provide a remove method. drivers with NULL remove are
> non-removable :-)
Actually the remove() callback can be NULL, it's just missing module_exit
function that makes a module not unloadable.
--
Regards,
Sylwester
next prev parent reply other threads:[~2013-06-26 15:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 14:21 [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Sylwester Nawrocki
2013-06-25 14:21 ` [PATCH v2 2/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi Sylwester Nawrocki
2013-06-25 14:21 ` [PATCH v2 3/5] video: exynos_mipi_dsim: Use generic PHY driver Sylwester Nawrocki
2013-06-25 15:08 ` Felipe Balbi
2013-06-25 14:21 ` [PATCH v2 4/5] exynos4-is: Use generic MIPI CSIS " Sylwester Nawrocki
2013-06-25 15:09 ` Felipe Balbi
2013-06-25 14:21 ` [PATCH v2 5/5] ARM: Samsung: Remove MIPI PHY setup code Sylwester Nawrocki
2013-06-25 15:09 ` Felipe Balbi
2013-06-25 15:06 ` [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Felipe Balbi
2013-06-25 17:44 ` Sylwester Nawrocki
2013-06-25 18:05 ` Tomasz Figa
2013-06-25 20:54 ` Felipe Balbi
2013-06-25 21:47 ` Sylwester Nawrocki
2013-06-26 5:23 ` Felipe Balbi
2013-06-26 11:21 ` Kishon Vijay Abraham I
2013-06-26 12:03 ` Sylwester Nawrocki
2013-06-26 12:22 ` Felipe Balbi
2013-06-26 12:48 ` Kishon Vijay Abraham I
2013-06-26 12:48 ` Kishon Vijay Abraham I
2013-06-26 15:00 ` Sylwester Nawrocki [this message]
2013-06-27 6:17 ` Felipe Balbi
2013-06-27 7:47 ` Andrzej Hajda
2013-06-27 7:51 ` Felipe Balbi
2013-06-27 8:49 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CB0212.3050103@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dh09.lee@samsung.com \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox