Re: [PATCH v7] V4L2: soc_camera: Renesas R-Car VIN driver

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 06/28/2013 03:58 AM, Vladimir Barinov wrote:

>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

>>> Add Renesas R-Car VIN (Video In) V4L2 driver.

>>> Based on the patch by Phil Edworthy <phil.edworthy@renesas.com>.

>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
>>> 'enum chip_id'
>>> values, reordered rcar_vin_id_table[] entries,  removed senseless
>>> parens from
>>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
>>> to the
>>> *if* statement  and used 'bool' values instead of 0/1 where
>>> necessary, removed
>>> unused macros, done some reformatting and clarified some comments.]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> Reviewing this iteration of the patch is still on my todo, in the
>> meantime you might verify whether it works on top of the for-3.11-3
>> branch of my

>> http://git.linuxtv.org/gliakhovetski/v4l-dvb.git

>> git-tree, or "next" after it's been pulled by Mauro and pushed
>> upstream. With that branch you shouldn't need any additional patches
>> andy more.

> Actually we need to apply/merge more patches here that enables VIN
> support on separate platform (like pinctrl/clock/setup/) :)

> Despite of above the rcar_vin driver works fine on Marzen board in
> v4l-dvb.git after adding soc_camera_host_ops clock_start/clock_stop.

    Guennadi, does that mean that we should rebase the driver to the 
branch that you've named now?

> Regards,
> Vladimir

WBR, Sergei