From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f179.google.com ([209.85.217.179]:58240 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753964Ab3F1RL2 (ORCPT ); Fri, 28 Jun 2013 13:11:28 -0400 Received: by mail-lb0-f179.google.com with SMTP id w20so1152053lbh.38 for ; Fri, 28 Jun 2013 10:11:26 -0700 (PDT) Message-ID: <51CDC3BE.1040603@cogentembedded.com> Date: Fri, 28 Jun 2013 21:11:26 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Guennadi Liakhovetski CC: Vladimir Barinov , mchehab@redhat.com, linux-media@vger.kernel.org, magnus.damm@gmail.com, linux-sh@vger.kernel.org, phil.edworthy@renesas.com, matsu@igel.co.jp Subject: Re: [PATCH v7] V4L2: soc_camera: Renesas R-Car VIN driver References: <201306220052.30572.sergei.shtylyov@cogentembedded.com> <51CCD1B7.3040009@cogentembedded.com> In-Reply-To: <51CCD1B7.3040009@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello. On 06/28/2013 03:58 AM, Vladimir Barinov wrote: >>> From: Vladimir Barinov >>> Add Renesas R-Car VIN (Video In) V4L2 driver. >>> Based on the patch by Phil Edworthy . >>> Signed-off-by: Vladimir Barinov >>> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed >>> 'enum chip_id' >>> values, reordered rcar_vin_id_table[] entries, removed senseless >>> parens from >>> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} >>> to the >>> *if* statement and used 'bool' values instead of 0/1 where >>> necessary, removed >>> unused macros, done some reformatting and clarified some comments.] >>> Signed-off-by: Sergei Shtylyov >> Reviewing this iteration of the patch is still on my todo, in the >> meantime you might verify whether it works on top of the for-3.11-3 >> branch of my >> http://git.linuxtv.org/gliakhovetski/v4l-dvb.git >> git-tree, or "next" after it's been pulled by Mauro and pushed >> upstream. With that branch you shouldn't need any additional patches >> andy more. > Actually we need to apply/merge more patches here that enables VIN > support on separate platform (like pinctrl/clock/setup/) :) > Despite of above the rcar_vin driver works fine on Marzen board in > v4l-dvb.git after adding soc_camera_host_ops clock_start/clock_stop. Guennadi, does that mean that we should rebase the driver to the branch that you've named now? > Regards, > Vladimir WBR, Sergei