Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

[Antti Palosaari <crope@iki.fi>]

On 07/18/2013 04:58 AM, Devin Heitmueller wrote:
> On Wed, Jul 17, 2013 at 9:33 PM, Luis Alves <ljalvs@gmail.com> wrote:
>> Hi,
>>
>> This i2c init should stop the interrupt storm that happens in some cards when the IR receiver in enabled.
>> It works perfectly in my TBS6981.
>
> What is at I2C address 0x4c?  Might be useful to have a comment in
> there explaining what this patch actually does.  This assumes you
> know/understand what it does - if you don't then a comment saying "I
> don't know why this is needed but my board doesn't work right without
> it" is just as valuable.
>
>> It would be good to test in other problematic cards.
>>
>> In this patch I've added the IR init to the TeVii S470/S471 (and some others that fall in the same case statment).
>> Other cards but these that suffer the same issue should also be tested.
>
> Without fully understanding the nature of this patch and what cards
> that it actually effects, it may make sense to move your board into a
> separate case statement.  Generally it's bad form to make changes like
> against other cards without any testing against those cards (otherwise
> you can introduce regressions).  Stick it in its own case statement,
> and users of the other boards can move their cards into that case
> statement *after* it's actually validated.
>
> Devin
>

hmm, I looked again the cx23885 driver.

0x4c == [0x98 >> 1] = "flatiron" == some internal block of the chip

There is routine which dumps registers out, 0x00 - 0x23
cx23885_flatiron_dump()

There is also existing routine to write those Flatiron registers. So, 
that direct I2C access could be shorten to:
cx23885_flatiron_write(dev, 0x1f, 0x80);
cx23885_flatiron_write(dev, 0x23, 0x80);


Unfortunately these two register names are not defined. Something clock 
or interrupt related likely.

regards
Antti

-- 
http://palosaari.fi/