From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-f41.google.com ([209.85.215.41]:40226 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174Ab3GYGzz (ORCPT ); Thu, 25 Jul 2013 02:55:55 -0400 Received: by mail-la0-f41.google.com with SMTP id fn20so1073840lab.14 for ; Wed, 24 Jul 2013 23:55:54 -0700 (PDT) Message-ID: <51F0CBF7.9080201@cogentembedded.com> Date: Thu, 25 Jul 2013 10:55:51 +0400 From: Vladimir Barinov MIME-Version: 1.0 To: Katsuya MATSUBARA CC: g.liakhovetski@gmx.de, mchehab@redhat.com, linux-media@vger.kernel.org, magnus.damm@gmail.com, linux-sh@vger.kernel.org, phil.edworthy@renesas.com, sergei.shtylyov@cogentembedded.com Subject: Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver References: <201307200314.35345.sergei.shtylyov@cogentembedded.com> <20130725.120113.75189051.matsu@igel.co.jp> In-Reply-To: <20130725.120113.75189051.matsu@igel.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Matsubara-san, On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote: > Hi Vladimir, > > Thank you for the revised patch. > > From: Sergei Shtylyov > Date: Sat, 20 Jul 2013 03:14:34 +0400 > >> From: Vladimir Barinov >> >> Add Renesas R-Car VIN (Video In) V4L2 driver. >> >> Based on the patch by Phil Edworthy. >> >> Signed-off-by: Vladimir Barinov >> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id' >> values, reordered rcar_vin_id_table[] entries, removed senseless parens from >> to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the >> *if* statement and used 'bool' values instead of 0/1 where necessary, removed >> unused macros, done some reformatting and clarified some comments.] >> Signed-off-by: Sergei Shtylyov >> >> --- >> This patch is against the 'media_tree.git' repo. >> >> Changes since version 7: >> - remove 'icd' field from 'struct rcar_vin_priv' in accordance with the commit >> f7f6ce2d09c86bd80ee11bd654a1ac1e8f5dfe13 ([media] soc-camera: move common code >> to soc_camera.c); >> - added mandatory clock_{start|stop}() methods in accordance with the commit >> a78fcc11264b824d9651b55abfeedd16d5cd8415 ([media] soc-camera: make .clock_ >> {start,stop} compulsory, .add / .remove optional). > From: Vladimir Barinov > Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver > Date: Sat, 22 Jun 2013 15:45:10 +0400 > >>> But, captured images are still incorrect that means wrong >>> order of fields desite '_BT' chosen for V4L2_STD_525_60. >>> >> I've ordered the NTSC camera. >> I will return once I get it. > Did you get an NTSC camera and see the field order issue > occurs on your BOCK-W board? Yes I did. > You may want to consider adding a workaround into > the VIN driver if the issue remains in the latest patch. Have you seen this patch https://linuxtv.org/patch/19278/ ? Regards, Vladimir