* [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
@ 2013-07-16 22:57 Alban Browaeys
2013-07-18 15:13 ` Frank Schäfer
2013-07-26 13:23 ` Hans Verkuil
0 siblings, 2 replies; 5+ messages in thread
From: Alban Browaeys @ 2013-07-16 22:57 UTC (permalink / raw)
To: Mauro Carvalho Chehab, linux-media; +Cc: linux-kernel, Alban Browaeys
Set the config structure pointer to the eeprom data pointer (data,
here eedata dereferenced) not the pointer to the pointer to
the eeprom data (eedata itself).
Signed-off-by: Alban Browaeys <prahal@yahoo.com>
---
drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
index 4851cc2..c4ff973 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
*eedata = data;
*eedata_len = len;
- dev_config = (void *)eedata;
+ dev_config = (void *)*eedata;
switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
case 0:
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
2013-07-16 22:57 [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data Alban Browaeys
@ 2013-07-18 15:13 ` Frank Schäfer
2013-07-18 15:51 ` Antti Palosaari
2013-07-26 13:23 ` Hans Verkuil
1 sibling, 1 reply; 5+ messages in thread
From: Frank Schäfer @ 2013-07-18 15:13 UTC (permalink / raw)
To: Alban Browaeys; +Cc: Mauro Carvalho Chehab, linux-media, Alban Browaeys
Am 17.07.2013 00:57, schrieb Alban Browaeys:
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2..c4ff973 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>
> *eedata = data;
> *eedata_len = len;
> - dev_config = (void *)eedata;
> + dev_config = (void *)*eedata;
>
> switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
> case 0:
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Thanks,
Frank
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
2013-07-18 15:13 ` Frank Schäfer
@ 2013-07-18 15:51 ` Antti Palosaari
2013-07-18 16:37 ` Frank Schäfer
0 siblings, 1 reply; 5+ messages in thread
From: Antti Palosaari @ 2013-07-18 15:51 UTC (permalink / raw)
To: Frank Schäfer
Cc: Alban Browaeys, Mauro Carvalho Chehab, linux-media,
Alban Browaeys
On 07/18/2013 06:13 PM, Frank Schäfer wrote:
> Am 17.07.2013 00:57, schrieb Alban Browaeys:
>> Set the config structure pointer to the eeprom data pointer (data,
>> here eedata dereferenced) not the pointer to the pointer to
>> the eeprom data (eedata itself).
>>
>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
>> ---
>> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
>> index 4851cc2..c4ff973 100644
>> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
>> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
>> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>>
>> *eedata = data;
>> *eedata_len = len;
>> - dev_config = (void *)eedata;
>> + dev_config = (void *)*eedata;
>>
>> switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>> case 0:
> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Does that SOB mean you will pick that patch via you tree, or was it only
a mistake?
I have thought few times what should I reply to patches which are for
modules I am maintaining and I will pick up and pull-request via own
tree. Usually I just reply "patch applied" but maybe Signed-off-by is
used for same.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
2013-07-18 15:51 ` Antti Palosaari
@ 2013-07-18 16:37 ` Frank Schäfer
0 siblings, 0 replies; 5+ messages in thread
From: Frank Schäfer @ 2013-07-18 16:37 UTC (permalink / raw)
To: Antti Palosaari
Cc: Alban Browaeys, Mauro Carvalho Chehab, linux-media,
Alban Browaeys
Am 18.07.2013 17:51, schrieb Antti Palosaari:
> On 07/18/2013 06:13 PM, Frank Schäfer wrote:
>> Am 17.07.2013 00:57, schrieb Alban Browaeys:
>>> Set the config structure pointer to the eeprom data pointer (data,
>>> here eedata dereferenced) not the pointer to the pointer to
>>> the eeprom data (eedata itself).
>>>
>>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
>>> ---
>>> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c
>>> b/drivers/media/usb/em28xx/em28xx-i2c.c
>>> index 4851cc2..c4ff973 100644
>>> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
>>> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
>>> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev,
>>> unsigned bus,
>>>
>>> *eedata = data;
>>> *eedata_len = len;
>>> - dev_config = (void *)eedata;
>>> + dev_config = (void *)*eedata;
>>>
>>> switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>>> case 0:
>> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
>
> Does that SOB mean you will pick that patch via you tree, or was it
> only a mistake?
No, I don't have a public tree.
Following the official rules (SubmittingPatches) strictly, it should
indeed have been Acked-by instead, sorry.
>
> I have thought few times what should I reply to patches which are for
> modules I am maintaining and I will pick up and pull-request via own
> tree. Usually I just reply "patch applied" but maybe Signed-off-by is
> used for same.
The problem is, that although there are rules, things like this are
handled slightly differently from project to project. (Coding style is
the other example ;) )
I'm always trying to adapt myself to the habits of a project, but
sometimes I make a mistake (especially when switching between multiple
projects).
Regards,
Frank
>
> regards
> Antti
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.
2013-07-16 22:57 [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data Alban Browaeys
2013-07-18 15:13 ` Frank Schäfer
@ 2013-07-26 13:23 ` Hans Verkuil
1 sibling, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2013-07-26 13:23 UTC (permalink / raw)
To: Alban Browaeys
Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, Alban Browaeys
Ouch. I'll take this for 3.11 and CC linux-stable for 3.10.
I'm amazed that this hasn't been discovered earlier.
Thanks!
Hans
On 07/17/2013 12:57 AM, Alban Browaeys wrote:
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2..c4ff973 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>
> *eedata = data;
> *eedata_len = len;
> - dev_config = (void *)eedata;
> + dev_config = (void *)*eedata;
>
> switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
> case 0:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-26 13:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 22:57 [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data Alban Browaeys
2013-07-18 15:13 ` Frank Schäfer
2013-07-18 15:51 ` Antti Palosaari
2013-07-18 16:37 ` Frank Schäfer
2013-07-26 13:23 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).