From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:30101 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967319Ab3HIGYP (ORCPT ); Fri, 9 Aug 2013 02:24:15 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MR900JKF33YBL50@mailout1.w1.samsung.com> for linux-media@vger.kernel.org; Fri, 09 Aug 2013 07:24:12 +0100 (BST) Message-id: <52048B0A.7010700@samsung.com> Date: Fri, 09 Aug 2013 08:24:10 +0200 From: Andrzej Hajda MIME-version: 1.0 To: Laurent Pinchart Cc: Sylwester Nawrocki , linux-media@vger.kernel.org, Kyungmin Park Subject: Re: [PATCH] V4L: s5c73m3: Add format propagation for TRY formats References: <1374677852-2006-1-git-send-email-s.nawrocki@samsung.com> <3766107.LzC3gBYZDo@avalon> In-reply-to: <3766107.LzC3gBYZDo@avalon> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Laurent, Thank you for the review. On 08/09/2013 12:58 AM, Laurent Pinchart wrote: > Hello, > > On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote: >> From: Andrzej Hajda >> >> Resolution set on ISP pad of S5C73M3-OIF subdev should be >> propagated to source pad for TRY and ACTIVE formats. >> The patch adds missing propagation for TRY format. > I might be missing something, but where's the propagation for the ACTIVE > format ? In case of active format there are no separate containers for the format of each pad, instead they shares common fields, precisely .oif_pix_size and .mbus_code. This way there is no need for extra code for format propagation. Regards Andrzej > >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Kyungmin Park >> Signed-off-by: Sylwester Nawrocki >> --- >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644 >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev >> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { >> mf = v4l2_subdev_get_try_format(fh, fmt->pad); >> *mf = fmt->format; >> + if (fmt->pad == OIF_ISP_PAD) { >> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD); >> + mf->width = fmt->format.width; >> + mf->height = fmt->format.height; >> + } >> } else { >> switch (fmt->pad) { >> case OIF_ISP_PAD: